Bug#993003: hydroffice.bag: tests fail with h5py 3

[Drew Parsons]

Source: hydroffice.bag
Version: 0.2.15-3
Severity: serious
Justification: breaks
Control: forwarded -1 https://github.com/hydroffice/hyo_bag/issues/3

hydroffice.bag fails debci tests with h5py 3

h5py changed the way the file mode is set when accessing .h5 files.
The mode now needs to be given explicitly.

Test logs report:


  .EEE.....
  ======================================================================
  ERROR: test_bag_File_filename (test_hydroffice_bag_base.TestBagBase)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/tmp/autopkgtest-lxc.niorsqvb/downtmp/autopkgtest_tmp/tests/test_hydroffice_bag_base.py", line 34, in test_bag_File_filename
      bag_0 = File(self.file_bag_0)
    File "/usr/lib/python3/dist-packages/hydroffice/bag/base.py", line 69, in __init__
      super(File, self).__init__(name=name, mode=mode, driver=driver,
    File "/usr/lib/python3/dist-packages/h5py/_debian_h5py_serial/_hl/files.py", line 444, in __init__
      fid = make_fid(name, mode, userblock_size,
    File "/usr/lib/python3/dist-packages/h5py/_debian_h5py_serial/_hl/files.py", line 215, in make_fid
      raise ValueError("Invalid mode; must be one of r, r+, w, w-, x, a")
  ValueError: Invalid mode; must be one of r, r+, w, w-, x, a
  
  ======================================================================
  ERROR: test_bag_File_open (test_hydroffice_bag_base.TestBagBase)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/tmp/autopkgtest-lxc.niorsqvb/downtmp/autopkgtest_tmp/tests/test_hydroffice_bag_base.py", line 30, in test_bag_File_open
      self.assertIsNotNone(File(self.file_bag_0))
    File "/usr/lib/python3/dist-packages/hydroffice/bag/base.py", line 69, in __init__
      super(File, self).__init__(name=name, mode=mode, driver=driver,
    File "/usr/lib/python3/dist-packages/h5py/_debian_h5py_serial/_hl/files.py", line 444, in __init__
      fid = make_fid(name, mode, userblock_size,
    File "/usr/lib/python3/dist-packages/h5py/_debian_h5py_serial/_hl/files.py", line 215, in make_fid
      raise ValueError("Invalid mode; must be one of r, r+, w, w-, x, a")
  ValueError: Invalid mode; must be one of r, r+, w, w-, x, a
  
  ======================================================================
  ERROR: test_bag_File_raise (test_hydroffice_bag_base.TestBagBase)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/tmp/autopkgtest-lxc.niorsqvb/downtmp/autopkgtest_tmp/tests/test_hydroffice_bag_base.py", line 27, in test_bag_File_raise
      File(self.file_fake_0)
    File "/usr/lib/python3/dist-packages/hydroffice/bag/base.py", line 69, in __init__
      super(File, self).__init__(name=name, mode=mode, driver=driver,
    File "/usr/lib/python3/dist-packages/h5py/_debian_h5py_serial/_hl/files.py", line 444, in __init__
      fid = make_fid(name, mode, userblock_size,
    File "/usr/lib/python3/dist-packages/h5py/_debian_h5py_serial/_hl/files.py", line 215, in make_fid
      raise ValueError("Invalid mode; must be one of r, r+, w, w-, x, a")
  ValueError: Invalid mode; must be one of r, r+, w, w-, x, a
  
  ----------------------------------------------------------------------
  Ran 9 tests in 0.003s
  
  FAILED (errors=3)





I recommend removing the hydroffice.bag packages from testing

    hydroffice.bag-doc
    hydroffice.bag-tools
    python3-hydroffice.bag
	    
	    
hyo_bag upstream hasn't been updated for more than 3 years.

I'm not sure how useful hydroffice.bag is anyway without the other
hydroffice components.



-- System Information:
Debian Release: bookworm/sid
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-8-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled