Bug#984123: fityk: ftbfs with GCC-11

[Matthias Klose]

Package: src:fityk
Version: 1.3.1-6
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/fityk_1.3.1-6_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
fityk.h:277:58: error: ISO C++17 does not allow dynamic exception specifications
  277 |                                                          throw(ExecuteError);
      |                                                          ^~~~~
fityk.h:289:55: error: ISO C++17 does not allow dynamic exception specifications
  289 |     const Var* get_variable(std::string const& name)  throw(ExecuteError);
      |                                                       ^~~~~
fityk.h:299:58: error: ISO C++17 does not allow dynamic exception specifications
  299 |                                                          throw(ExecuteError);
      |                                                          ^~~~~
fityk.h:303:58: error: ISO C++17 does not allow dynamic exception specifications
  303 |                                                          throw(ExecuteError);
      |                                                          ^~~~~
fityk.h:308:58: error: ISO C++17 does not allow dynamic exception specifications
  308 |                                                          throw(ExecuteError);
      |                                                          ^~~~~
fityk.h:320:47: error: ISO C++17 does not allow dynamic exception specifications
  320 |     realt get_wssr(int dataset=ALL_DATASETS)  throw(ExecuteError);
      |                                               ^~~~~
fityk.h:323:46: error: ISO C++17 does not allow dynamic exception specifications
  323 |     realt get_ssr(int dataset=ALL_DATASETS)  throw(ExecuteError);
      |                                              ^~~~~
fityk.h:326:51: error: ISO C++17 does not allow dynamic exception specifications
  326 |     realt get_rsquared(int dataset=ALL_DATASETS)  throw(ExecuteError);
      |                                                   ^~~~~
fityk.h:329:44: error: ISO C++17 does not allow dynamic exception specifications
  329 |     int get_dof(int dataset=ALL_DATASETS)  throw(ExecuteError);
      |                                            ^~~~~
fityk.h:333:54: error: ISO C++17 does not allow dynamic exception specifications
  333 |     get_covariance_matrix(int dataset=ALL_DATASETS)  throw(ExecuteError);
      |                                                      ^~~~~
make[5]: *** [Makefile:1198: libfityk_la-lexer.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
In file included from eparser.cpp:19:
func.h:90:29: error: ISO C++17 does not allow dynamic exception specifications
   90 |                             throw(ExecuteError); // exc. spec. is used by SWIG
      |                             ^~~~~
func.h:104:25: error: ISO C++17 does not allow dynamic exception specifications
  104 |                         throw(ExecuteError) // exc. spec. is used by SWIG
      |                         ^~~~~
make[5]: *** [Makefile:1205: libfityk_la-eparser.lo] Error 1
logic.cpp: In member function ‘void fityk::DataKeeper::do_import_dataset(bool, int, const fityk::LoadSpec&, fityk::BasicContext*, fityk::ModelManager&)’:
logic.cpp:224:5: warning: ‘template<class> class std::auto_ptr’ is deprecated: use 'std::unique_ptr' instead [-Wdeprecated-declarations]
  224 |     auto_ptr<Data> auto_d;
      |     ^~~~~~~~
In file included from /usr/include/c++/11/memory:76,
                 from /usr/include/boost/smart_ptr/detail/sp_counted_impl.hpp:35,
                 from /usr/include/boost/smart_ptr/detail/shared_count.hpp:27,
                 from /usr/include/boost/smart_ptr/shared_ptr.hpp:17,
                 from /usr/include/boost/shared_ptr.hpp:17,
                 from tplate.h:9,
                 from mgr.h:9,
                 from logic.h:8,
                 from logic.cpp:5:
/usr/include/c++/11/bits/unique_ptr.h:57:28: note: declared here
   57 |   template<typename> class auto_ptr;
      |                            ^~~~~~~~
make[5]: *** [Makefile:1191: libfityk_la-view.lo] Error 1
make[5]: *** [Makefile:1184: libfityk_la-logic.lo] Error 1
make[5]: Leaving directory '/<<PKGBUILDDIR>>/fityk'
make[4]: *** [Makefile:614: all] Error 2
make[4]: Leaving directory '/<<PKGBUILDDIR>>/fityk'
make[3]: *** [Makefile:1344: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:815: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make[1]: *** [debian/rules:12: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2