Bug#1015388: double-conversion: ftbfs with LTO (link time optimization) enabled

[Matthias Klose]

Package: src:double-conversion
Version: 3.1.7-4
Severity: minor
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-lto

This package currently fails to build (at least on the amd64
architecture) with link time optimizations enabled.  For a background
for LTO please see

https://wiki.debian.org/ToolChain/LTO

The goal is to enable this optimization by default in an upcoming
Debian release in dpkg-buildflags for 64bit architectures.  The goal
is to get this package to build with link time optimizations, or to
explicitly disable link time optimizations for this package build.

To reproduce the build failure, enable the lto optimization in
testing/unstable by adding "optimize=+lto" to DEB_BUILD_MAINT_OPTIONS
in the debian/rules file, or if this macro is unset, just set it:

export DEB_BUILD_MAINT_OPTIONS = optimize=+lto

Please try to fix the build with lto enabled, fixing the packaging or
forwarding the issue upstream. If the issue cannot be fixed,
explicitly disallow building the package with lto by adding to your
rules file:

export DEB_BUILD_MAINT_OPTIONS = optimize=-lto

or adding that string to your existing setting of DEB_BUILD_MAINT_OPTIONS.

The full build log can be found at:
http://qa-logs.debian.net/2022/06/09/dpkglto/double-conversion_3.1.7-4_unstable_dpkglto.log
The last lines of the build log are at the end of this report.

[...]
x86_64-linux-gnu-g++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I.  -c -o test/cctest/test-fixed-dtoa.o test/cctest/test-fixed-dtoa.cc
x86_64-linux-gnu-g++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I.  -c -o test/cctest/test-ieee.o test/cctest/test-ieee.cc
x86_64-linux-gnu-g++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I.  -c -o test/cctest/test-strtod.o test/cctest/test-strtod.cc
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -fPIC -c double-conversion/bignum-dtoa.cc -o debian/shared/bignum-dtoa.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -fPIC -c double-conversion/bignum.cc -o debian/shared/bignum.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -fPIC -c double-conversion/cached-powers.cc -o debian/shared/cached-powers.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -fPIC -c double-conversion/double-to-string.cc -o debian/shared/double-to-string.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -fPIC -c double-conversion/fast-dtoa.cc -o debian/shared/fast-dtoa.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -fPIC -c double-conversion/fixed-dtoa.cc -o debian/shared/fixed-dtoa.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -fPIC -c double-conversion/string-to-double.cc -o debian/shared/string-to-double.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -fPIC -c double-conversion/strtod.cc -o debian/shared/strtod.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -c double-conversion/bignum-dtoa.cc -o debian/static/bignum-dtoa.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -c double-conversion/bignum.cc -o debian/static/bignum.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -c double-conversion/cached-powers.cc -o debian/static/cached-powers.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -c double-conversion/double-to-string.cc -o debian/static/double-to-string.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -c double-conversion/fast-dtoa.cc -o debian/static/fast-dtoa.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -c double-conversion/fixed-dtoa.cc -o debian/static/fixed-dtoa.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -c double-conversion/string-to-double.cc -o debian/static/string-to-double.o
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -Idouble-conversion/ -I. -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -O2 -O2 -c double-conversion/strtod.cc -o debian/static/strtod.o
x86_64-linux-gnu-g++ -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -shared -Wl,-soname=libdouble-conversion.so.3 -o libdouble-conversion.so.3.1 debian/shared/bignum-dtoa.o debian/shared/bignum.o debian/shared/cached-powers.o debian/shared/double-to-string.o debian/shared/fast-dtoa.o debian/shared/fixed-dtoa.o debian/shared/string-to-double.o debian/shared/strtod.o
ar r libdouble-conversion.a debian/static/bignum-dtoa.o debian/static/bignum.o debian/static/cached-powers.o debian/static/double-to-string.o debian/static/fast-dtoa.o debian/static/fixed-dtoa.o debian/static/string-to-double.o debian/static/strtod.o
ar: creating libdouble-conversion.a
ln -snf libdouble-conversion.so.3.1 libdouble-conversion.so.3
ln -snf libdouble-conversion.so.3 libdouble-conversion.so
x86_64-linux-gnu-g++ -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o run_tests test/cctest/cctest.o test/cctest/gay-fixed.o test/cctest/gay-precision.o test/cctest/gay-shortest-single.o test/cctest/gay-shortest.o test/cctest/test-bignum-dtoa.o test/cctest/test-bignum.o test/cctest/test-conversions.o test/cctest/test-diy-fp.o test/cctest/test-dtoa.o test/cctest/test-fast-dtoa.o test/cctest/test-fixed-dtoa.o test/cctest/test-ieee.o test/cctest/test-strtod.o libdouble-conversion.a
sed -e 's/@DEB_HOST_MULTIARCH@/x86_64-linux-gnu/g' \
	< debian/double-conversion.pc.in > debian/double-conversion.pc
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
	make -j8 test
make[1]: Entering directory '/<<PKGBUILDDIR>>'
./run_tests
Ran 84 tests.
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_auto_install
   dh_install
   dh_installdocs
   dh_installchangelogs
   dh_perl
   dh_link
   dh_strip_nondeterminism
   dh_compress
   dh_fixperms
   debian/rules override_dh_missing
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_missing --fail-missing
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_dwz -a
   dh_strip -a
   dh_makeshlibs -a
dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/libdouble-conversion3/DEBIAN/symbols doesn't match completely debian/libdouble-conversion3.symbols
--- debian/libdouble-conversion3.symbols (libdouble-conversion3_3.1.7-4_amd64)
+++ dpkg-gensymbolsW0MBoy	2022-06-10 09:08:20.630899905 +0000
@@ -2,8 +2,8 @@
 * Build-Depends-Package: libdouble-conversion-dev
  (c++)"double double_conversion::StringToDoubleConverter::StringTo<double>(char const*, int, int*) const at Base" 3.1.7
  (c++)"double double_conversion::StringToDoubleConverter::StringTo<double>(unsigned short const*, int, int*) const at Base" 3.1.7
- (c++)"double double_conversion::StringToDoubleConverter::StringToIeee<char const*>(char const*, int, bool, int*) const at Base" 2.0.0
- (c++)"double double_conversion::StringToDoubleConverter::StringToIeee<unsigned short const*>(unsigned short const*, int, bool, int*) const at Base" 2.0.0
+#MISSING: 3.1.7-4# (c++)"double double_conversion::StringToDoubleConverter::StringToIeee<char const*>(char const*, int, bool, int*) const at Base" 2.0.0
+#MISSING: 3.1.7-4# (c++)"double double_conversion::StringToDoubleConverter::StringToIeee<unsigned short const*>(unsigned short const*, int, bool, int*) const at Base" 2.0.0
  (c++)"double_conversion::Bignum::AddBignum(double_conversion::Bignum const&)@Base" 2.0.0
  (c++|arch=armel armhf hppa any-i386 m68k mips mipsel powerpc powerpcse sh4 sparc x32)"double_conversion::Bignum::AddUInt64(unsigned long long)@Base" 2.0.0
  (c++|arch=alpha amd64 arm64 kfreebsd-amd64 mips64el ppc64 ppc64el s390x sparc64)"double_conversion::Bignum::AddUInt64(unsigned long)@Base" 2.0.0
dh_makeshlibs: error: failing due to earlier errors
make: *** [debian/rules:23: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2