Bug#1023457: sundials: FTBFS against hypre 2.26 and petsc 3.18

[Drew Parsons]

Source: sundials
Version: 5.8.0+dfsg-1
Severity: serious
Justification: FTBFS
Control: affects -1 libhypre-dev libpetsc-real3.18-dev

Testing the build of sundials against Hypre 2.6 and PETSc 3.18, both
available now in experimental, nvector/parhyp fails with the error
message:

[ 55%] Linking C executable ark_diurnal_kry_ph
cd /home/drew/projects/misc/build/sundials-5.8.0+dfsg/debian/build/examples/arkode/C_parhyp && /usr/bin/cmake -E cmake_link_script CMakeFiles/ark_diurnal_kry_ph.dir/link.txt --verbose=1
/usr/bin/mpicc -fcommon -Wl,-z,relro -Wl,-z,now CMakeFiles/ark_diurnal_kry_ph.dir/ark_diurnal_kry_ph.c.o -o ark_diurnal_kry_ph  -Wl,-rpath,/home/drew/projects/misc/build/sundials-5.8.0+dfsg/debian/build/src/arkode:/home/drew/projects/misc/build/sundials-5.8.0+dfsg/debian/build/src/nvector/parhyp ../../../src/arkode/libsundials_arkode.so.4.8.0 ../../../src/nvector/parhyp/libsundials_nvecparhyp.so.5.8.0 -lm /usr/lib/x86_64-linux-gnu/librt.a -lHYPRE -lHYPRE 
In file included from /usr/lib/petscdir/petsc3.18/x86_64-linux-gnu-real/include/petscsys.h:1274,
                 from /usr/lib/petscdir/petsc3.18/x86_64-linux-gnu-real/include/petscvec.h:9,
                 from /usr/lib/petscdir/petsc3.18/x86_64-linux-gnu-real/include/petscmat.h:7,
                 from /usr/lib/petscdir/petsc3.18/x86_64-linux-gnu-real/include/petscdm.h:6,
                 from /home/drew/projects/misc/build/sundials-5.8.0+dfsg/examples/arkode/C_petsc/ark_petsc_ex25.c:32:
/home/drew/projects/misc/build/sundials-5.8.0+dfsg/examples/arkode/C_petsc/ark_petsc_ex25.c: In function ‘main’:
/usr/lib/petscdir/petsc3.18/x86_64-linux-gnu-real/include/petscoptions.h:182:5: error: expected expression before ‘do’
  182 |     do { \
      |     ^~
/home/drew/projects/misc/build/sundials-5.8.0+dfsg/examples/arkode/C_petsc/ark_petsc_ex25.c:112:10: note: in expansion of macro ‘PetscOptionsBegin’
  112 |   ierr = PetscOptionsBegin(PETSC_COMM_WORLD,NULL,"Advection-reaction options","");
      |          ^~~~~~~~~~~~~~~~~


Actually the error is specifically triggered from petscoptions.h, so
perhaps the problem is in petsc 3.18 not sundials. And line 182 in
petscoptions.h does look malformed.  We'll close or move this bug
to petsc if that proves to be the source of the problem. Might have to
check the petsc source repo upstream.



-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
merged-usr: no
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.0.0-2-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled