Bug#1019282: ignition-common: missing header include, causes build failures of software using this lib

[Steve Langasek]

Package: ignition-common
Version: 4.5.1+ds-1
Severity: serious
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu kinetic ubuntu-patch

Hi José Luis,

In Ubuntu, ignition-launch is failing to build from source because of an
error in an ignition-common header, Image.hh, which references memcpy() but
does not include string.h which declares it.

The attached patch to ignition-common fixes the build failure of
ignition-launch (not yet in Debian) and may help the buildability of other
software using ignition-common.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru ignition-common-4.5.1+ds/debian/control ignition-common-4.5.1+ds/debian/control
--- ignition-common-4.5.1+ds/debian/control	2022-07-19 05:53:51.000000000 -0700
+++ ignition-common-4.5.1+ds/debian/control	2022-09-06 12:26:16.000000000 -0700
@@ -1,6 +1,5 @@
 Source: ignition-common
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian Science Maintainers <debian-science-maintainers at lists.alioth.debian.org>
+Maintainer: Debian Science Maintainers <debian-science-maintainers at lists.alioth.debian.org>
 Uploaders: Jose Luis Rivero <jrivero at osrfoundation.org>
 Section: science
 Priority: optional
diff -Nru ignition-common-4.5.1+ds/debian/patches/missing-include.patch ignition-common-4.5.1+ds/debian/patches/missing-include.patch
--- ignition-common-4.5.1+ds/debian/patches/missing-include.patch	1969-12-31 16:00:00.000000000 -0800
+++ ignition-common-4.5.1+ds/debian/patches/missing-include.patch	2022-09-06 12:26:10.000000000 -0700
@@ -0,0 +1,18 @@
+Description: add missing include to header
+ Image.hh references memcpy() but doesn't include string.h which declares it.
+Author: Steve Langasek <steve.langasek at ubuntu.com>
+Last-Update: 2022-09-06
+Forwarded: no
+
+Index: ignition-common-4.5.1+ds/graphics/include/ignition/common/Image.hh
+===================================================================
+--- ignition-common-4.5.1+ds.orig/graphics/include/ignition/common/Image.hh
++++ ignition-common-4.5.1+ds/graphics/include/ignition/common/Image.hh
+@@ -21,6 +21,7 @@
+ #include <memory>
+ #include <string>
+ #include <vector>
++#include <string.h>
+ #include <ignition/math/Color.hh>
+ #include <ignition/common/graphics/Export.hh>
+ 
diff -Nru ignition-common-4.5.1+ds/debian/patches/series ignition-common-4.5.1+ds/debian/patches/series
--- ignition-common-4.5.1+ds/debian/patches/series	2022-06-27 15:41:21.000000000 -0700
+++ ignition-common-4.5.1+ds/debian/patches/series	2022-09-06 12:24:35.000000000 -0700
@@ -3,3 +3,4 @@
 0004-Disable-failing-tests-due-to-copyrighted-files.patch
 0005-Use-system-tinyobjloader.patch
 0003-Disable-performance-test.patch
+missing-include.patch