Bug#1043659: cba: Fails to build source after successful build

[Lucas Nussbaum]

Source: cba
Version: 0.3.6-6
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package cba
> dpkg-buildpackage: info: source version 0.3.6-6
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Scott Talbert <swt at techie.net>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> ( cd /<<PKGBUILDDIR>>/src; make clean )
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
> rm -f cbeam_class.o cba_main.o
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
> ( cd /<<PKGBUILDDIR>>/src/gui; make clean )
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src/gui'
> rm -f /<<PKGBUILDDIR>>/src/gui/cbeam_class.o /<<PKGBUILDDIR>>/src/gui/cbaGUI_drawings.o /<<PKGBUILDDIR>>/src/gui/cbaGUI_dialogs.o /<<PKGBUILDDIR>>/src/gui/cbaGUI.o
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src/gui'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building cba using existing ./cba_0.3.6.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: error: cannot represent change to src/cba: binary file contents changed
> dpkg-source: error: add src/cba in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: warning: executable mode 0755 of 'src/cba' will not be represented in diff
> dpkg-source: error: cannot represent change to src/gui/cba-gtk: binary file contents changed
> dpkg-source: error: add src/gui/cba-gtk in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: warning: executable mode 0755 of 'src/gui/cba-gtk' will not be represented in diff
> dpkg-source: error: unrepresentable changes to source
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/cba_0.3.6-6_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.