Bug#1043917: armadillo: Fails to build source after successful build

[Lucas Nussbaum]

Source: armadillo
Version: 1:11.4.2+dfsg-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package armadillo
> dpkg-buildpackage: info: source version 1:11.4.2+dfsg-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Kumar Appaiah <akumar at debian.org>
>  dpkg-source --before-build .
> dpkg-source: info: using options from armadillo-11.4.2+dfsg/debian/source/options: --extend-diff-ignore=^\.travis\.yml$
>  fakeroot debian/rules clean
> dh_testdir
> dh_testroot
> rm -f build-stamp
> rm -rf debian/doc_gen
> [ ! -f Makefile ] || /usr/bin/make clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> /usr/bin/make  -f CMakeFiles/Makefile2 clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> /usr/bin/make  -f CMakeFiles/armadillo.dir/build.make CMakeFiles/armadillo.dir/clean
> make[3]: Entering directory '/<<PKGBUILDDIR>>'
> /usr/bin/cmake -P CMakeFiles/armadillo.dir/cmake_clean.cmake
> make[3]: Leaving directory '/<<PKGBUILDDIR>>'
> /usr/bin/make  -f tests1/CMakeFiles/smoke_test.dir/build.make tests1/CMakeFiles/smoke_test.dir/clean
> make[3]: Entering directory '/<<PKGBUILDDIR>>'
> cd /<<PKGBUILDDIR>>/tests1 && /usr/bin/cmake -P CMakeFiles/smoke_test.dir/cmake_clean.cmake
> make[3]: Leaving directory '/<<PKGBUILDDIR>>'
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f config.guess config.sub Makefile
> rm -f CMakeCache.txt cmake_install.cmake
> rm -rf CMakeFiles
> rm -f install_manifest.txt include/armadillo_bits/config.hpp examples/Makefile
> rm -f ArmadilloConfig.cmake ArmadilloConfigVersion.cmake 
> rm -rf InstallFiles tmp *.o a.out
> dh_clean  --exclude ./src/include/armadillo_bits/dgemm_proto.hpp.orig
>  dpkg-source -b .
> dpkg-source: info: using options from armadillo-11.4.2+dfsg/debian/source/options: --extend-diff-ignore=^\.travis\.yml$
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building armadillo using existing ./armadillo_11.4.2+dfsg.orig.tar.xz
> dpkg-source: warning: ignoring deletion of file include/armadillo_bits/config.hpp, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  armadillo-11.4.2+dfsg/CTestTestfile.cmake
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/CMakeDirectoryInformation.cmake
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/progress.marks
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/DependInfo.cmake
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/build.make
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/cmake_clean.cmake
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/compiler_depend.internal
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/compiler_depend.make
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/compiler_depend.ts
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/depend.make
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/flags.make
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/link.txt
>  armadillo-11.4.2+dfsg/tests1/CMakeFiles/smoke_test.dir/progress.make
>  armadillo-11.4.2+dfsg/tests1/CTestTestfile.cmake
>  armadillo-11.4.2+dfsg/tests1/Makefile
>  armadillo-11.4.2+dfsg/tests1/cmake_install.cmake
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/armadillo_11.4.2+dfsg-1.diff._XWHeD
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/armadillo_11.4.2+dfsg-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.