Bug#1044722: dials: Fails to build source after successful build

[Lucas Nussbaum]

Source: dials
Version: 3.12.1+dfsg3-5
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package dials
> dpkg-buildpackage: info: source version 3.12.1+dfsg3-5
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Roland Mas <lolando at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --with python3 --buildsystem=pybuild
>    dh_auto_clean -O--buildsystem=pybuild
> 	pybuild --clean -i python{version} -p 3.11
> I: pybuild base:275: python3.11 setup.py clean 
> /usr/lib/python3/dist-packages/setuptools/dist.py:509: InformationOnly: Normalizing '3.9.dev' to '3.9.dev0'
>   self.metadata.version = self._normalize_version(
> Found 89 dials dispatchers
> running clean
> removing '/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_dials/build' (and everything under it)
> 'build/bdist.linux-x86_64' does not exist -- can't clean it
> 'build/scripts-3.11' does not exist -- can't clean it
> 	rm -rf .pybuild/
> 	find . -name \*.pyc -exec rm {} \;
>    dh_autoreconf_clean -O--buildsystem=pybuild
>    dh_clean -O--buildsystem=pybuild
> 	rm -f debian/debhelper-build-stamp
> 	rm -rf debian/.debhelper/
> 	rm -f -- debian/dials.substvars debian/python3-dials.substvars debian/python3-dials.postinst.debhelper debian/python3-dials.prerm.debhelper debian/files
> 	rm -fr -- debian/dials/ debian/tmp/ debian/python3-dials/
> 	find .  \( \( \
> 		\( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \
> 	        \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
> 		 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
> 		 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
> 		 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
> 		\) -exec rm -f {} + \) -o \
> 		\( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \) \)
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building dials using existing ./dials_3.12.1+dfsg3.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: file dials-3.12.1+dfsg3/src/dials.egg-info/SOURCES.txt has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  dials-3.12.1+dfsg3/src/dials.egg-info/PKG-INFO
>  dials-3.12.1+dfsg3/src/dials.egg-info/SOURCES.txt
>  dials-3.12.1+dfsg3/src/dials.egg-info/dependency_links.txt
>  dials-3.12.1+dfsg3/src/dials.egg-info/entry_points.txt
>  dials-3.12.1+dfsg3/src/dials.egg-info/requires.txt
>  dials-3.12.1+dfsg3/src/dials.egg-info/top_level.txt
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/dials_3.12.1+dfsg3-5.diff.4zETBW
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/dials_3.12.1+dfsg3-5_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.