Bug#1041059: FTBFS against suitesparse 7

[Sébastien Villemot]

Source: libdogleg
Version: 0.15.4-2
Severity: important
Tags: ftbfs
User: sebastien at debian.org
Usertags: suitesparse7

Dear Maintainer,

libdogleg fails to build against suitesparse 7, which is currently available in
experimental.

More precisely, it tries to include cholmod_function.h, which has disappeared
in that release. If I understand correctly, this header was a backward
compatibility layer consisting of a few macros. I guess you should either stop
using these macros, or embed a copy of cholmod_function.h from suitessparse 5.

I attach a build log.

Cheers,

--
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  https://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  https://www.debian.org
-------------- next part --------------
 dpkg-buildpackage -us -uc -ui -B
dpkg-buildpackage: info: source package libdogleg
dpkg-buildpackage: info: source version 0.15.4-2
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Dima Kogan <dkogan at debian.org>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   debian/rules override_dh_auto_clean
make[1]: Entering directory '/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4'
dh_auto_clean
dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1 clean
make[2]: Entering directory '/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4'
rm -f libdogleg.so* *.o *.a *.d libdogleg.a libdogleg.so libdogleg.so.2.0.15.4 libdogleg.so.2 libdogleg.3 sample
make[2]: Leaving directory '/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4'
rm -f libdogleg.html pod2htm*.tmp
make[1]: Leaving directory '/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4'
   dh_clean
dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
 debian/rules build-arch
dh build-arch
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_update_autotools_config -a
   dh_auto_configure -a
dh_auto_configure: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   debian/rules override_dh_auto_build
make[1]: Entering directory '/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4'
dh_auto_build
dh_auto_build: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1
make[2]: Entering directory '/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4'
cc -g -O2 -ffile-prefix-map=/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4=. -fstack-protector-strong -Wformat -Werror=format-security -ggdb  -Wall -Wextra -MMD  -fno-omit-frame-pointer -I/usr/include/suitesparse --std=gnu99 -Wdate-time -D_FORTIFY_SOURCE=2  -c -o dogleg.o dogleg.c
dogleg.c:19:10: fatal error: suitesparse/cholmod_function.h: No such file or directory
   19 | #include <suitesparse/cholmod_function.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [<builtin>: dogleg.o] Error 1
make[2]: Leaving directory '/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4'
dh_auto_build: error: make -j1 returned exit code 2
make[1]: *** [debian/rules:10: override_dh_auto_build] Error 25
make[1]: Leaving directory '/home/sebastien/debian/transitions/suitesparse7/libdogleg-0.15.4'
make: *** [debian/rules:7: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2