Bug#1054481: shiny-server: installs multiple copies of shiny-server.service once dh_installsystemd installs to /usr

[Helmut Grohne]

Package: shiny-server
Version: 1.5.20.1002-1
Severity: normal
Tags: patch
User: helmutg at debian.org
Usertags: dep17m2

We want to modify dh_installsystemd such that it installs units below
/usr in order to finalize the /usr-merge transition via DEP17. Once
doing so, it installs shiny-server.service three times. It installs it
to /lib via dh_install, then overwrites it from override_dh_install and
finally dh_installsystemd will in future install below /usr/lib. Doing
so is a policy violation and therefore this bug will become
release-critical once I upload debhelper. I'm attaching a patch to
delete the first two methods and only leave dh_installsystemd.

Helmut
-------------- next part --------------
diff -Nru node-shiny-server-1.5.20.1002/debian/changelog node-shiny-server-1.5.20.1002/debian/changelog
--- node-shiny-server-1.5.20.1002/debian/changelog	2023-02-23 20:07:13.000000000 +0100
+++ node-shiny-server-1.5.20.1002/debian/changelog	2023-10-24 11:12:23.000000000 +0200
@@ -1,3 +1,10 @@
+node-shiny-server (1.5.20.1002-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Install systemd unit only once. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Tue, 24 Oct 2023 11:12:23 +0200
+
 node-shiny-server (1.5.20.1002-1) unstable; urgency=medium
 
   * Team Upload.
diff -Nru node-shiny-server-1.5.20.1002/debian/install node-shiny-server-1.5.20.1002/debian/install
--- node-shiny-server-1.5.20.1002/debian/install	2023-02-23 20:06:24.000000000 +0100
+++ node-shiny-server-1.5.20.1002/debian/install	2023-10-24 11:12:21.000000000 +0200
@@ -1,3 +1,2 @@
 config/init.d/debian/*		etc/init.d
 config/*.config			etc/shiny-server
-debian/shiny-server.service	lib/systemd/system
diff -Nru node-shiny-server-1.5.20.1002/debian/rules node-shiny-server-1.5.20.1002/debian/rules
--- node-shiny-server-1.5.20.1002/debian/rules	2023-02-23 20:06:24.000000000 +0100
+++ node-shiny-server-1.5.20.1002/debian/rules	2023-10-24 11:12:23.000000000 +0200
@@ -31,8 +31,6 @@
 	dh_install
 	mkdir -p debian/$(INSTALL_SOURCE)/etc/logrotate.d
 	cp -a config/logrotate debian/$(INSTALL_SOURCE)/etc/logrotate.d/shiny-server
-	mkdir -p debian/$(INSTALL_SOURCE)/lib/systemd/system
-	cp -a config/systemd/shiny-server.service debian/$(INSTALL_SOURCE)/lib/systemd/system/
 	find debian/$(INSTALL_SOURCE) -name COPYING -delete
 	find debian/$(INSTALL_SOURCE) -name GIT_VERSION -delete
 	find debian/$(INSTALL_SOURCE) -name build -type l -delete