Bug#1068369: coda: FTBFS due to -Werror=implicit-function-declaration.

[Bas Couwenberg]

Source: coda
Version: 2.25.2-1
Severity: serious
Tags: upstream ftbfs patch
Justification: makes the package in question unusable or mostly so
User: debian-gis at lists.debian.org
Usertags: hdf-4.3

Dear Maintainer,

Your package FTBFS while performing test rebuilds with HDF 4.3.20.

The attached patch resolves the issue by adding the appropriate includes to fix the -Werror=implicit-function-declaration issues.

Kind Regards,

Bas
-------------- next part --------------
diff -Nru coda-2.25.2/debian/changelog coda-2.25.2/debian/changelog
--- coda-2.25.2/debian/changelog	2024-03-17 09:05:21.000000000 +0100
+++ coda-2.25.2/debian/changelog	2024-04-04 10:00:40.000000000 +0200
@@ -1,3 +1,10 @@
+coda (2.25.2-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Rebuild with HDF 4.3.0.
+
+ -- Bas Couwenberg <sebastic at debian.org>  Thu, 04 Apr 2024 10:00:40 +0200
+
 coda (2.25.2-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru coda-2.25.2/debian/patches/implicit-function-declaration.patch coda-2.25.2/debian/patches/implicit-function-declaration.patch
--- coda-2.25.2/debian/patches/implicit-function-declaration.patch	1970-01-01 01:00:00.000000000 +0100
+++ coda-2.25.2/debian/patches/implicit-function-declaration.patch	2024-04-04 10:00:40.000000000 +0200
@@ -0,0 +1,37 @@
+Description: Fix FTBFS due to -Werror=implicit-function-declaration.
+Author: Bas Couwenberg <sebastic at debian.org>
+
+--- a/libcoda/coda-hdf4-cursor.c
++++ b/libcoda/coda-hdf4-cursor.c
+@@ -32,6 +32,8 @@
+ #include "coda-hdf4-internal.h"
+ 
+ #include <assert.h>
++#include <stdlib.h>
++#include <string.h>
+ 
+ static int get_native_type_size(coda_native_type type)
+ {
+--- a/libcoda/coda-hdf4-type.c
++++ b/libcoda/coda-hdf4-type.c
+@@ -32,6 +32,9 @@
+ #include "coda-hdf4-internal.h"
+ 
+ #include <assert.h>
++#include <stdio.h>
++#include <stdlib.h>
++#include <string.h>
+ 
+ /* Compatibility with versions before HDF4r2 */
+ #ifndef _HDF_SDSVAR
+--- a/libcoda/coda-hdf4.c
++++ b/libcoda/coda-hdf4.c
+@@ -32,6 +32,8 @@
+ #include "coda-hdf4-internal.h"
+ 
+ #include <assert.h>
++#include <stdlib.h>
++#include <string.h>
+ 
+ static int init_GRImages(coda_hdf4_product *product)
+ {
diff -Nru coda-2.25.2/debian/patches/series coda-2.25.2/debian/patches/series
--- coda-2.25.2/debian/patches/series	2024-03-17 09:05:21.000000000 +0100
+++ coda-2.25.2/debian/patches/series	2024-04-04 10:00:40.000000000 +0200
@@ -3,3 +3,4 @@
 hdf4-alt-libs.patch
 detect_libaec.patch
 hdf4-deps.patch
+implicit-function-declaration.patch