Bug#1065777: clblas: FTBFS on arm{el,hf}: /<<PKGBUILDDIR>>/src/library/blas/gens/symv.c:955:29: error: implicit declaration of function =?UTF-8?Q?=E2=80=98abs=E2=80=99; ?= did you mean ‘fabs’? [-Werror=implicit-function-declaration]

[Steve Langasek]

Package: clblas
Followup-For: Bug #1065777
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Apologies, the patch I attached fixed a real missing include, but not the
one mentioned in this bug and the package still failed to build.  Attached
is a patch that has passed build testing locally with
DEB_CFLAGS_APPEND=-Werror=implicit-function-declaration in Ubuntu.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru clblas-2.12/debian/patches/no-implicit-declarations.patch clblas-2.12/debian/patches/no-implicit-declarations.patch
--- clblas-2.12/debian/patches/no-implicit-declarations.patch	1969-12-31 16:00:00.000000000 -0800
+++ clblas-2.12/debian/patches/no-implicit-declarations.patch	2024-04-09 14:42:11.000000000 -0700
@@ -0,0 +1,30 @@
+Description: Add missing stdlib.h includes
+Author: Steve Langasek <steve.langasek at canonical.com>
+Bug-Debian: https://bugs.debian.org/1065777
+Last-Update: 2024-04-09
+Forwarded: no
+
+Index: clblas-2.12/src/library/blas/gens/gemv.c
+===================================================================
+--- clblas-2.12.orig/src/library/blas/gens/gemv.c
++++ clblas-2.12/src/library/blas/gens/gemv.c
+@@ -21,6 +21,7 @@
+ 
+ #include <string.h>
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <assert.h>
+ #include <math.h>
+ #include <clblas_stddef.h>
+Index: clblas-2.12/src/library/blas/gens/symv.c
+===================================================================
+--- clblas-2.12.orig/src/library/blas/gens/symv.c
++++ clblas-2.12/src/library/blas/gens/symv.c
+@@ -21,6 +21,7 @@
+ 
+ #include <string.h>
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <assert.h>
+ #include <math.h>
+ #include <clblas_stddef.h>
diff -Nru clblas-2.12/debian/patches/series clblas-2.12/debian/patches/series
--- clblas-2.12/debian/patches/series	2023-09-28 16:21:54.000000000 -0700
+++ clblas-2.12/debian/patches/series	2024-04-09 14:40:35.000000000 -0700
@@ -9,3 +9,4 @@
 Fix-double-literals.patch
 Fix-null-pointer-crash.patch
 Fix-local-variables-not-declared-in-outermost-scope.patch
+no-implicit-declarations.patch