Bug#1089273: spnavcfg: FTBFS with make 4.4.1

[Santiago Vila]

Package: src:spnavcfg
Version: 1.1-1
User: debian-qa at lists.debian.org
Usertags: make-4.4
Severity: important
Tags: ftbfs

Dear Maintainer,

This package fails to build from source with Make 4.4.1, most likely because of
changes in $(shell) environment handling: environment variables exported from
Makefiles are now made available to commands invoked using $(shell), which
can cause issues with recursive definitions in particular. See
https://salsa.debian.org/debian/make/-/blob/master/debian/NEWS for a complete
list of backward-incompatible changes since Make 4.3.

Below you will find how the builds end, hopefully the most relevant
part from the build log. A full build log is available here:

https://people.debian.org/~sanvila/make-4.4/build-logs/

Make 4.4.1 is currently available in experimental and will hopefully
soon be uploaded to unstable, at which time this bug will become
release-critical.

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Please reach out to the Make maintainer, Stephen Kitt <skitt at debian.org> if
you need help fixing this.

--------------------------------------------------------------------------------
  debian/rules binary
dh binary
    dh_update_autotools_config
    dh_autoreconf
    dh_auto_configure
	./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --runstatedir=/run --disable-maintainer-mode --disable-dependency-tracking
configuring spnavcfg...
   prefix: /usr
   optimize for speed: yes
   include debugging symbols: yes

creating Makefile ...

Done. You can now type make (or gmake) to compile spnavcfg.

    dh_auto_build
	make -j2
make[1]: Entering directory '/<<PKGBUILDDIR>>'
cc -pedantic -Wall -g -O3 -I. -I/usr/include -fPIC -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MMD -Wdate-time -D_FORTIFY_SOURCE=2  -c -o src/spnavcfg.o src/spnavcfg.c
g++ -std=c++11 -pedantic -Wall -g -O3 -I. -I/usr/include -fPIC `pkg-config --cflags Qt5Core Qt5Gui Qt5Widgets` -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MMD -Wdate-time -D_FORTIFY_SOURCE=2  -c -o src/main.o src/main.cc
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++
uic -o ui_mainwin.h ui/spnavcfg.ui
uic -o ui_bnmaprow.h ui/bnmaprow.ui
uic -o ui_about.h ui/about.ui
moc -o src/ui.moc.cc -I. -I/usr/include src/ui.h
rcc -o res.cc ui/spnavcfg.qrc
g++ -std=c++11 -pedantic -Wall -g -O3 -I. -I/usr/include -fPIC `pkg-config --cflags Qt5Core Qt5Gui Qt5Widgets` -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MMD -Wdate-time -D_FORTIFY_SOURCE=2  -c -o src/ui.o src/ui.cc
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++
g++ -std=c++11 -pedantic -Wall -g -O3 -I. -I/usr/include -fPIC `pkg-config --cflags Qt5Core Qt5Gui Qt5Widgets` -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MMD -Wdate-time -D_FORTIFY_SOURCE=2  -c -o src/ui.moc.o src/ui.moc.cc
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++
g++ -o spnavcfg src/spnavcfg.o src/main.o src/ui.o src/ui.moc.o src/ui.moc.o res.cc -L/usr/lib `pkg-config --libs Qt5Core Qt5Gui Qt5Widgets` -lspnav -lX11 -Wl,-z,relro -Wl,-z,now
/usr/bin/ld: src/ui.moc.o: in function `MainWin::metaObject() const':
./src/ui.moc.cc:134: multiple definition of `MainWin::metaObject() const'; src/ui.moc.o:./src/ui.moc.cc:134: first defined here
/usr/bin/ld: src/ui.moc.o:./src/ui.moc.cc:123: multiple definition of `MainWin::staticMetaObject'; src/ui.moc.o:./src/ui.moc.cc:123: first defined here
/usr/bin/ld: src/ui.moc.o: in function `MainWin::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)':
./src/ui.moc.cc:103: multiple definition of `MainWin::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)'; src/ui.moc.o:./src/ui.moc.cc:103: first defined here
/usr/bin/ld: src/ui.moc.o: in function `MainWin::qt_metacast(char const*)':
./src/ui.moc.cc:139: multiple definition of `MainWin::qt_metacast(char const*)'; src/ui.moc.o:./src/ui.moc.cc:139: first defined here
/usr/bin/ld: src/ui.moc.o: in function `MainWin::qt_metacall(QMetaObject::Call, int, void**)':
./src/ui.moc.cc:147: multiple definition of `MainWin::qt_metacall(QMetaObject::Call, int, void**)'; src/ui.moc.o:./src/ui.moc.cc:147: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:31: spnavcfg] Error 1
rm src/ui.moc.cc
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j2 returned exit code 2
make: *** [debian/rules:16: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------