Bug#1064607: python-vispy-doc: unhandled failures to build documentation can occur

[James Addison]

Source: python-vispy
Version: 0.14.1-2
Severity: important

Dear Maintainer,

In the debian/rules build instructions for python-vispy-doc, the make step[1]
that builds the package documentation (by using a Makefile in the 'doc' dir) is
followed by another command, separated by a semicolon:

  HOME=$$(mktemp -d);PYTHONPATH=`pybuild --print {build_dir} -p$$(py3versions -dv)` HOME=$$HOME xvfb-run make -C doc html;rm -r $$HOME

This means if the (middle) documentation build step fails -- a situation that
would usually and correctly result in a FTBFS -- then the subsequent (rm)
command is evaluated next, and it is the exit code from _that_ latter command
that will determine the success/failure of the make target, and the overall doc
package build.

It may be possible to separate the commands onto separate lines (with care to
make sure that variables are created and access correctly), or less invasively
to use boolean AND (&&) separators instead of semi-colons.

Regards,
James

[1] - https://sources.debian.org/src/python-vispy/0.14.1-2/debian/rules/#L18