Bug#1075703: yorick-ml4: ftbfs with GCC-14

[Matthias Klose]

Package: src:yorick-ml4
Version: 0.6.0-4
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/yorick-ml4_0.6.0-4_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
   debian/rules override_dh_auto_clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make Y_MAKEDIR=/usr/lib/yorick Y_EXE=/usr/bin/yorick clean
make[2]: Entering directory '/<<PKGBUILDDIR>>'
rm -f *~ '#'* core* *.core a.out yinit.* ywrap.* *.dep so_locations Make.tmp
rm -f Y_HOME.txt
rm -f ml4.o yorick libml4.a ml4.so ml4.def 
rm -rf binaries
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_clean
 debian/rules build
dh build
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make COPT_DEFAULT="" \
        Y_CFLAGS="-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2" \
        Y_LDFLAGS="-Wl,-z,relro"
make[2]: Entering directory '/<<PKGBUILDDIR>>'
cc  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -fPIC -DPLUG_IN -I. -I/usr/lib/yorick/include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o ml4.o ml4.c
ml4.c: In function ‘Y_ml4read’:
ml4.c:379:17: error: initialization of ‘int *’ from incompatible pointer type ‘long int *’ [-Wincompatible-pointer-types]
  379 |     int *data = a->value.l;
      |                 ^
ml4.c:415:33: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
  415 |     if (DEBUG) printf("strlen: %d\n",strlen((void *)a->value.q[0]));
      |                                ~^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                 |    |
      |                                 int  size_t {aka long unsigned int}
      |                                %ld
ml4.c:312:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  312 |   fread(&mrows,sizeof(int),1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c:313:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  313 |   fread(&mcols,sizeof(int),1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c:314:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  314 |   fread(&imagf,sizeof(int),1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c:316:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  316 |   fread(&namelen,sizeof(int),1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c:337:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  337 |   fread(tempvarname,(unsigned int)namelen,1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c: In function ‘matskip’:
ml4.c:456:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  456 |   fread(&mrows,sizeof(long),1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c:457:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  457 |   fread(&mcols,sizeof(long),1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c:458:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  458 |   fread(&imagf,sizeof(long),1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c:460:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  460 |   fread(&namelen,sizeof(long),1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ml4.c:476:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  476 |   fread(tempvarname,(unsigned int)namelen,1,fs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [<builtin>: ml4.o] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules:10: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:7: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2