Bug#1077424: scilab: FTBFS: sci_gateway/c/sci_javalibrarypath.c:43:63: error: passing argument 5 of 'createMatrixOfString' from incompatible pointer type [-Wincompatible-pointer-types]

[Lucas Nussbaum]

Source: scilab
Version: 2024.1.0+dfsg-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240728 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> /bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../modules/core/includes  -I/usr/lib/jvm/java-17-openjdk-amd64/include -I/usr/lib/jvm/java-17-openjdk-amd64/include/linux -I./includes/ -I./src/c -I../../modules/ast/includes/ast/ -I../../modules/ast/includes/exps/ -I../../modules/ast/includes/operations/ -I../../modules/ast/includes/parse/ -I../../modules/ast/includes/symbol/ -I../../modules/ast/includes/system_env/ -I../../modules/ast/includes/types/ -I../../modules/api_scilab/includes/ -I../../modules/call_scilab/includes/ -I../../modules/output_stream/includes/ -I../../modules/localization/includes/ -I../../modules/string/includes/ -I../../modules/functions_manager/includes/ -I../../modules/fileio/includes/ -I../../modules/dynamic_link/includes -I../../modules/preferences/includes/ -I/usr/include/libxml2   -Wdate-time -D_FORTIFY_SOURCE=2 -DNDEBUG -g -O2 -m64 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT sci_gateway/c/libscijvm_la-sci_javalibrarypath.lo -MD -MP -MF sci_gateway/c/.deps/libscijvm_la-sci_javalibrarypath.Tpo -c -o sci_gateway/c/libscijvm_la-sci_javalibrarypath.lo `test -f 'sci_gateway/c/sci_javalibrarypath.c' || echo './'`sci_gateway/c/sci_javalibrarypath.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../modules/core/includes -I/usr/lib/jvm/java-17-openjdk-amd64/include -I/usr/lib/jvm/java-17-openjdk-amd64/include/linux -I./includes/ -I./src/c -I../../modules/ast/includes/ast/ -I../../modules/ast/includes/exps/ -I../../modules/ast/includes/operations/ -I../../modules/ast/includes/parse/ -I../../modules/ast/includes/symbol/ -I../../modules/ast/includes/system_env/ -I../../modules/ast/includes/types/ -I../../modules/api_scilab/includes/ -I../../modules/call_scilab/includes/ -I../../modules/output_stream/includes/ -I../../modules/localization/includes/ -I../../modules/string/includes/ -I../../modules/functions_manager/includes/ -I../../modules/fileio/includes/ -I../../modules/dynamic_link/includes -I../../modules/preferences/includes/ -I/usr/include/libxml2 -Wdate-time -D_FORTIFY_SOURCE=2 -DNDEBUG -g -O2 -m64 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT sci_gateway/c/libscijvm_la-sci_javalibrarypath.lo -MD -MP -MF sci_gateway/c/.deps/libscijvm_la-sci_javalibrarypath.Tpo -c sci_gateway/c/sci_javalibrarypath.c  -fPIC -DPIC -o sci_gateway/c/.libs/libscijvm_la-sci_javalibrarypath.o
> sci_gateway/c/sci_javalibrarypath.c: In function 'sci_javalibrarypath':
> sci_gateway/c/sci_javalibrarypath.c:43:63: error: passing argument 5 of 'createMatrixOfString' from incompatible pointer type [-Wincompatible-pointer-types]
>    43 |         createMatrixOfString(pvApiCtx, Rhs + 1, iRows, iCols, pstLibrarypath);
>       |                                                               ^~~~~~~~~~~~~~
>       |                                                               |
>       |                                                               char **
> In file included from ../../modules/api_scilab/includes/api_scilab.h:38,
>                  from sci_gateway/c/sci_javalibrarypath.c:25:
> ../../modules/api_scilab/includes/api_stack_string.h:65:97: note: expected 'const char * const*' but argument is of type 'char **'
>    65 | SciErr createMatrixOfString(void* _pvCtx, int _iVar, int _iRows, int _iCols, const char* const* _pstStrings);
>       |                                                                              ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
> make[4]: *** [Makefile:1220: sci_gateway/c/libscijvm_la-sci_javalibrarypath.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/07/28/scilab_2024.1.0+dfsg-2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240728;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240728&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.