Bug#1072655: silx: no-opencl tests fail with pytest8.2

[Chris Peterson]

Package: silx
Version: 2.0.1+dfsg-3
Severity: normal
Tags: patch
X-Debbugs-Cc: chris.peterson at canonical.com
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu oracular ubuntu-patch


Dear maintainer,

silx's autopkgtests (the no-opencl tests in partiuclar) fail with pytest 8.2
due to a known issue upstream [1]. It hasn't been committed upstream,
but there is an open PR to fix the issue [2]. I cherry-picked the fix
and applied it in Ubuntu to resolve the issue.

  * d/p/0010-SpecFile-deallocation-issue.patch: Fix an issue with pytest
    runner segfaulting with Pytest 8.2+ (LP: 2068521).

Thanks for considering the patch.

[1] https://github.com/silx-kit/silx/issues/4128
[2] https://github.com/silx-kit/silx/pull/4129/

-- System Information:
Debian Release: trixie/sid
  APT prefers oracular
  APT policy: (500, 'oracular'), (100, 'oracular-proposed')
Architecture: amd64 (x86_64)

Kernel: Linux 6.8.0-31-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru silx-2.0.1+dfsg/debian/patches/0010-SpecFile-deallocation-issue.patch silx-2.0.1+dfsg/debian/patches/0010-SpecFile-deallocation-issue.patch
--- silx-2.0.1+dfsg/debian/patches/0010-SpecFile-deallocation-issue.patch	1969-12-31 16:00:00.000000000 -0800
+++ silx-2.0.1+dfsg/debian/patches/0010-SpecFile-deallocation-issue.patch	2024-06-05 12:21:03.000000000 -0700
@@ -0,0 +1,24 @@
+Description: Fixes autopkgtests with pytest 8.2+
+ The clean up for tests in src/silx/io/test/test_specfilewrapper.py was
+ causing the pytest runner to segfault in pytest 8.2, causing the autopkgtests
+ to fail.
+Author: Chris Peterson <chris.peterson at canonical.com>
+Origin: upstream, https://github.com/silx-kit/silx/pull/4129/
+Bug: https://github.com/silx-kit/silx/issues/4128
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/silx/+bug/2068521
+Last-Update: 2024-06-05
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/src/silx/io/specfile.pyx
++++ b/src/silx/io/specfile.pyx
+@@ -658,8 +658,8 @@
+         else:
+             self.filename = filename
+ 
+-    def __dealloc__(self):
+-        """Destructor: Calls SfClose(self.handle)"""
++    def __del__(self):
++        """Finalizer: Calls SfClose(self.handle)"""
+         self.close()
+ 
+     def close(self):
diff -Nru silx-2.0.1+dfsg/debian/patches/series silx-2.0.1+dfsg/debian/patches/series
--- silx-2.0.1+dfsg/debian/patches/series	2024-04-16 01:47:09.000000000 -0700
+++ silx-2.0.1+dfsg/debian/patches/series	2024-06-05 12:05:23.000000000 -0700
@@ -2,3 +2,4 @@
 0007-python3.10-fix.patch
 0009-Skip-testing-nanmin-on-float64-arrays-on-mips-el.patch
 0008-deal-with-h5py-until-we-solved-1051781.patch
+0010-SpecFile-deallocation-issue.patch