Bug#1066227: armci-mpi: FTBFS: tests/contrib/non-blocking/overlap.c:660:17: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: armci-mpi
Version: 0.3.1~beta-7
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /bin/bash ./libtool  --tag=CC   --mode=link mpicc.mpich  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection    -Wl,-z,relro -o tests/contrib/transp1D/transp1D-c tests/contrib/transp1D/transp1D-c.o libarmci-mpich.la 
> libtool: link: mpicc.mpich -g -O2 -Werror=implicit-function-declaration "-ffile-prefix-map=/<<PKGBUILDDIR>>=." -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wl,-z -Wl,relro -o tests/contrib/transp1D/transp1D-c tests/contrib/transp1D/transp1D-c.o  ./.libs/libarmci-mpich.a
> mpicc.mpich -DHAVE_CONFIG_H -I. -I./src  -I./src -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection   -c -o tests/contrib/non-blocking/overlap.o tests/contrib/non-blocking/overlap.c
> tests/contrib/non-blocking/overlap.c: In function ‘main’:
> tests/contrib/non-blocking/overlap.c:660:17: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]
>   660 |     time_seed = time(NULL);
>       |                 ^~~~
> tests/contrib/non-blocking/overlap.c:45:1: note: ‘time’ is defined in header ‘<time.h>’; did you forget to ‘#include <time.h>’?
>    44 | #include <armci.h>
>   +++ |+#include <time.h>
>    45 | 
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:1778: tests/contrib/non-blocking/overlap.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/armci-mpi_0.3.1~beta-7_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.