Bug#1066232: palp: FTBFS: class.c:313:27: error: implicit declaration of function ‘DB_to_Hodge’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: palp
Version: 2.20-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DPACKAGE_NAME=\"palp\" -DPACKAGE_TARNAME=\"palp\" -DPACKAGE_VERSION=\"2.1\" -DPACKAGE_STRING=\"palp\ 2.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"palp\" -DVERSION=\"2.1\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_LIMITS_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MALLOC=1 -DHAVE_REALLOC=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DPOLY_Dmax=6 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o class_6d_x-class.o `test -f 'class.c' || echo './'`class.c
> class.c: In function ‘main’:
> class.c:313:27: error: implicit declaration of function ‘DB_to_Hodge’ [-Werror=implicit-function-declaration]
>   313 |   else if(HFlag=='c')     DB_to_Hodge(dbin, dbout, vf, vt,_P);
>       |                           ^~~~~~~~~~~
> class.c:314:27: error: implicit declaration of function ‘Sort_Hodge’ [-Werror=implicit-function-declaration]
>   314 |   else if(HFlag=='s')     Sort_Hodge(dbin, dbout);
>       |                           ^~~~~~~~~~
> class.c:315:27: error: implicit declaration of function ‘Test_Hodge_file’ [-Werror=implicit-function-declaration]
>   315 |   else if(HFlag=='f')     Test_Hodge_file(polyi,_P);
>       |                           ^~~~~~~~~~~~~~~
> class.c:316:27: error: implicit declaration of function ‘Test_Hodge_db’ [-Werror=implicit-function-declaration]
>   316 |   else if(HFlag=='t')     Test_Hodge_db(dbin);
>       |                           ^~~~~~~~~~~~~
> class.c:317:27: error: implicit declaration of function ‘Extract_from_Hodge_db’ [-Werror=implicit-function-declaration]
>   317 |   else if(HFlag=='e')     Extract_from_Hodge_db(dbin,x_string,_P);
>       |                           ^~~~~~~~~~~~~~~~~~~~~
> class.c: In function ‘LocalPrintUsage’:
> class.c:224:1: warning: ignoring return value of ‘scanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   224 | scanf("%s",&hc);
>       | ^~~~~~~~~~~~~~~
> LG.c: In function ‘Fast_c9_VaHo’:
> LG.c:645:45: warning: ‘__builtin_memset’ writing 516 bytes into a region of size 512 [-Wstringop-overflow=]
>   645 |      for(i=0;i<=WM;i++) woG[i]=woS[i]=woA[i]=0;
>       |                                       ~~~~~~^~
> LG.c:642:28: note: at offset 1024 into destination object of size 1536 allocated by ‘malloc’
>   642 |      wo[0] = woG = (int *) malloc(WM*3*sizeof(int));
>       |                            ^~~~~~~~~~~~~~~~~~~~~~~~
> gcc -DPACKAGE_NAME=\"palp\" -DPACKAGE_TARNAME=\"palp\" -DPACKAGE_VERSION=\"2.1\" -DPACKAGE_STRING=\"palp\ 2.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"palp\" -DVERSION=\"2.1\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_LIMITS_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MALLOC=1 -DHAVE_REALLOC=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DPOLY_Dmax=6 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o class_6d_x-Subpoly.o `test -f 'Subpoly.c' || echo './'`Subpoly.c
> LG.c: In function ‘WIndex_HTrace’:
> LG.c:687:45: warning: ‘__builtin_memset’ writing 516 bytes into a region of size 512 [-Wstringop-overflow=]
>   687 |      for(i=0;i<=WM;i++) woG[i]=woS[i]=woA[i]=0;
>       |                                       ~~~~~~^~
> LG.c:684:28: note: at offset 1024 into destination object of size 1536 allocated by ‘malloc’
>   684 |      wo[0] = woG = (int *) malloc(WM*3*sizeof(int));
>       |                            ^~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[1]: *** [GNUmakefile:1331: class_6d_x-class.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/palp_2.20-2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.