Bug#1066361: atlas: FTBFS: probe_comp.c:653:13: error: implicit declaration of function ‘CompIsClang’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: atlas
Version: 3.10.3-14
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -I/<<PKGBUILDDIR>>/build/..//CONFIG/include  -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -fcf-protection -DATL_DYLIBS -c /<<PKGBUILDDIR>>/build/..//CONFIG/src/probe_comp.c
> /<<PKGBUILDDIR>>/build/..//CONFIG/src/probe_comp.c: In function ‘GetStandardCompName’:
> /<<PKGBUILDDIR>>/build/..//CONFIG/src/probe_comp.c:653:13: error: implicit declaration of function ‘CompIsClang’ [-Werror=implicit-function-declaration]
>   653 |    else if (CompIsClang(comp))
>       |             ^~~~~~~~~~~
> /<<PKGBUILDDIR>>/build/..//CONFIG/src/probe_comp.c: In function ‘SelectBestGcc’:
> /<<PKGBUILDDIR>>/build/..//CONFIG/src/probe_comp.c:1140:24: error: implicit declaration of function ‘CompIsMinGW’ [-Werror=implicit-function-declaration]
>  1140 |       if (!USEMINGW && CompIsMinGW(gccs[i]))
>       |                        ^~~~~~~~~~~
> In file included from /<<PKGBUILDDIR>>/build/..//CONFIG/include/atlconf_misc.h:4,
>                  from /<<PKGBUILDDIR>>/build/..//CONFIG/include/atlconf.h:150,
>                  from /<<PKGBUILDDIR>>/build/..//CONFIG/src/probe_comp.c:1:
> /<<PKGBUILDDIR>>/build/..//CONFIG/include/atlas_sys.h: In function ‘atlsys’:
> /<<PKGBUILDDIR>>/build/..//CONFIG/include/atlas_sys.h:262:10: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   262 |          system(sp);
>       |          ^~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:92: probe_comp.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/atlas_3.10.3-14_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.