Bug#1066543: ucx: FTBFS: cc1plus: error: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++ [-Werror]

[Lucas Nussbaum]

Source: ucx
Version: 1.16.0+ds-4
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /bin/bash ../../../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../../../..  -DCPU_FLAGS="" -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -nostdlib  -std=c++11 -c -o libucxperf_la-ucp_tests.lo `test -f 'ucp_tests.cc' || echo './'`ucp_tests.cc
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../.. -DCPU_FLAGS= -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wno-pointer-sign -Werror-implicit-function-declaration -Wno-format-zero-length -Wnested-externs -Wshadow -Werror=declaration-after-statement -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c libperf_memory.c  -fPIC -DPIC -DUCX_SHARED_LIB -o .libs/libucxperf_la-libperf_memory.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../.. -DCPU_FLAGS= -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wno-pointer-sign -Werror-implicit-function-declaration -Wno-format-zero-length -Wnested-externs -Wshadow -Werror=declaration-after-statement -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c libperf.c  -fPIC -DPIC -DUCX_SHARED_LIB -o .libs/libucxperf_la-libperf.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../.. -DCPU_FLAGS= -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wno-pointer-sign -Werror-implicit-function-declaration -Wno-format-zero-length -Wnested-externs -Wshadow -Werror=declaration-after-statement -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c libperf_thread.c  -fPIC -DPIC -DUCX_SHARED_LIB -o .libs/libucxperf_la-libperf_thread.o
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../../.. -DCPU_FLAGS= -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -nostdlib -std=c++11 -c uct_tests.cc  -fPIC -DPIC -o .libs/libucxperf_la-uct_tests.o
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../../.. -DCPU_FLAGS= -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -nostdlib -std=c++11 -c ucp_tests.cc  -fPIC -DPIC -o .libs/libucxperf_la-ucp_tests.o
> cc1plus: error: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++ [-Werror]
> cc1plus: error: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++ [-Werror]
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../.. -DCPU_FLAGS= -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wno-pointer-sign -Werror-implicit-function-declaration -Wno-format-zero-length -Wnested-externs -Wshadow -Werror=declaration-after-statement -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c libperf_thread.c -o libucxperf_la-libperf_thread.o >/dev/null 2>&1
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../.. -DCPU_FLAGS= -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wno-pointer-sign -Werror-implicit-function-declaration -Wno-format-zero-length -Wnested-externs -Wshadow -Werror=declaration-after-statement -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c libperf_memory.c -o libucxperf_la-libperf_memory.o >/dev/null 2>&1
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../.. -DCPU_FLAGS= -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src -I/usr/include/hsa -I/usr/include/hip -O3 -g -Wall -Werror -funwind-tables -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wno-pointer-sign -Werror-implicit-function-declaration -Wno-format-zero-length -Wnested-externs -Wshadow -Werror=declaration-after-statement -fopenmp -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c libperf.c -o libucxperf_la-libperf.o >/dev/null 2>&1
> cc1plus: all warnings being treated as errors
> make[4]: *** [Makefile:674: libucxperf_la-ucp_tests.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/ucx_1.16.0+ds-4_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.