Bug#1066635: yorick-curses: FTBFS: ywrap_static.c:14:3: error: implicit declaration of function =?UTF-8?Q?=E2=80=98kbdinit=E2=80=99; ?= did you mean ‘Y_kbdinit’? [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: yorick-curses
Version: 0.1-6
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -fPIC -DPLUG_IN -I. -I/usr/lib/yorick/include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o ywrap_static.o ywrap_static.c
> ywrap_static.c: In function ‘Y_kbdinit’:
> ywrap_static.c:14:3: error: implicit declaration of function ‘kbdinit’; did you mean ‘Y_kbdinit’? [-Werror=implicit-function-declaration]
>    14 |   kbdinit();
>       |   ^~~~~~~
>       |   Y_kbdinit
> ywrap_static.c: In function ‘Y_kbd’:
> ywrap_static.c:24:16: error: implicit declaration of function ‘kbd’; did you mean ‘Y_kbd’? [-Werror=implicit-function-declaration]
>    24 |   PushIntValue(kbd(yarg_si(0)));
>       |                ^~~
>       |                Y_kbd
> ywrap_static.c: In function ‘Y_kbdend’:
> ywrap_static.c:34:3: error: implicit declaration of function ‘kbdend’; did you mean ‘Y_kbdend’? [-Werror=implicit-function-declaration]
>    34 |   kbdend();
>       |   ^~~~~~
>       |   Y_kbdend
> ywrap_static.c: In function ‘Y_cgetlines’:
> ywrap_static.c:265:16: error: implicit declaration of function ‘getlines’; did you mean ‘getline’? [-Werror=implicit-function-declaration]
>   265 |   PushIntValue(getlines());
>       |                ^~~~~~~~
>       |                getline
> ywrap_static.c: In function ‘Y_cgetcols’:
> ywrap_static.c:275:16: error: implicit declaration of function ‘getcols’; did you mean ‘Y_cgetcols’? [-Werror=implicit-function-declaration]
>   275 |   PushIntValue(getcols());
>       |                ^~~~~~~
>       |                Y_cgetcols
> ywrap_static.c: In function ‘Y_cnodelay’:
> ywrap_static.c:365:16: error: implicit declaration of function ‘ynodelay’; did you mean ‘nodelay’? [-Werror=implicit-function-declaration]
>   365 |   PushIntValue(ynodelay(yarg_si(0)));
>       |                ^~~~~~~~
>       |                nodelay
> ywrap_static.c: In function ‘Y_cnotimeout’:
> ywrap_static.c:375:16: error: implicit declaration of function ‘ynotimeout’; did you mean ‘notimeout’? [-Werror=implicit-function-declaration]
>   375 |   PushIntValue(ynotimeout(yarg_si(0)));
>       |                ^~~~~~~~~~
>       |                notimeout
> ywrap_static.c: In function ‘Y_ckeypad’:
> ywrap_static.c:385:16: error: implicit declaration of function ‘ykeypad’; did you mean ‘keypad’? [-Werror=implicit-function-declaration]
>   385 |   PushIntValue(ykeypad(yarg_si(0)));
>       |                ^~~~~~~
>       |                keypad
> ywrap_static.c: In function ‘Y_cmeta’:
> ywrap_static.c:395:16: error: implicit declaration of function ‘ymeta’; did you mean ‘meta’? [-Werror=implicit-function-declaration]
>   395 |   PushIntValue(ymeta(yarg_si(0)));
>       |                ^~~~~
>       |                meta
> ywrap_static.c: In function ‘Y_cintrflush’:
> ywrap_static.c:405:16: error: implicit declaration of function ‘yintrflush’; did you mean ‘intrflush’? [-Werror=implicit-function-declaration]
>   405 |   PushIntValue(yintrflush(yarg_si(0)));
>       |                ^~~~~~~~~~
>       |                intrflush
> ywrap_static.c: In function ‘Y_cscrollok’:
> ywrap_static.c:415:16: error: implicit declaration of function ‘yscrollok’; did you mean ‘scrollok’? [-Werror=implicit-function-declaration]
>   415 |   PushIntValue(yscrollok(yarg_si(0)));
>       |                ^~~~~~~~~
>       |                scrollok
> ywrap_static.c: In function ‘Y_cleaveok’:
> ywrap_static.c:425:16: error: implicit declaration of function ‘yleaveok’; did you mean ‘leaveok’? [-Werror=implicit-function-declaration]
>   425 |   PushIntValue(yleaveok(yarg_si(0)));
>       |                ^~~~~~~~
>       |                leaveok
> ywrap_static.c: In function ‘Y_cclearok’:
> ywrap_static.c:435:16: error: implicit declaration of function ‘yclearok’; did you mean ‘clearok’? [-Werror=implicit-function-declaration]
>   435 |   PushIntValue(yclearok(yarg_si(0)));
>       |                ^~~~~~~~
>       |                clearok
> ywrap_static.c: In function ‘Y_cidlok’:
> ywrap_static.c:445:16: error: implicit declaration of function ‘yidlok’; did you mean ‘idlok’? [-Werror=implicit-function-declaration]
>   445 |   PushIntValue(yidlok(yarg_si(0)));
>       |                ^~~~~~
>       |                idlok
> cc1: some warnings being treated as errors
> make[2]: *** [<builtin>: ywrap_static.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/yorick-curses_0.1-6_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.