Bug#1066681: scilab: FTBFS: sci_gateway/c/sci_getURL.c:43:5: error: implicit declaration of function ‘Sciwarning’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: scilab
Version: 2024.0.0+dfsg-5
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../modules/core/includes  -I./includes/ -I./src/c/ -I./src/cpp/ -I../../modules/ast/includes/ast/ -I../../modules/ast/includes/exps/ -I../../modules/ast/includes/operations/ -I../../modules/ast/includes/parse/ -I../../modules/ast/includes/symbol/ -I../../modules/ast/includes/system_env/ -I../../modules/ast/includes/types/ -I../../modules/api_scilab/includes -I../../modules/output_stream/includes -I../../modules/functions_manager/includes -I../../modules/string/includes -I../../modules/io/includes -I../../modules/threads/includes -I../../modules/console/includes -I../../modules/localization/includes -I../../modules/dynamic_link/includes -I../../modules/preferences/includes -I/usr/include/hdf5/serial -I/usr/include/libxml2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection  -Wdate-time -D_FORTIFY_SOURCE=2 -DNDEBUG -g -O2 -m64 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT sci_gateway/c/libscifileio_la-sci_getURL.lo -MD -MP -MF sci_gateway/c/.deps/libscifileio_la-sci_getURL.Tpo -c -o sci_gateway/c/libscifileio_la-sci_getURL.lo `test -f 'sci_gateway/c/sci_getURL.c' || echo './'`sci_gateway/c/sci_getURL.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../modules/core/includes -I./includes/ -I./src/c/ -I./src/cpp/ -I../../modules/ast/includes/ast/ -I../../modules/ast/includes/exps/ -I../../modules/ast/includes/operations/ -I../../modules/ast/includes/parse/ -I../../modules/ast/includes/symbol/ -I../../modules/ast/includes/system_env/ -I../../modules/ast/includes/types/ -I../../modules/api_scilab/includes -I../../modules/output_stream/includes -I../../modules/functions_manager/includes -I../../modules/string/includes -I../../modules/io/includes -I../../modules/threads/includes -I../../modules/console/includes -I../../modules/localization/includes -I../../modules/dynamic_link/includes -I../../modules/preferences/includes -I/usr/include/hdf5/serial -I/usr/include/libxml2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -DNDEBUG -g -O2 -m64 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT sci_gateway/c/libscifileio_la-sci_getURL.lo -MD -MP -MF sci_gateway/c/.deps/libscifileio_la-sci_getURL.Tpo -c sci_gateway/c/sci_getURL.c  -fPIC -DPIC -o sci_gateway/c/.libs/libscifileio_la-sci_getURL.o
> sci_gateway/c/sci_getURL.c: In function ‘sci_getURL’:
> sci_gateway/c/sci_getURL.c:43:5: error: implicit declaration of function ‘Sciwarning’ [-Werror=implicit-function-declaration]
>    43 |     Sciwarning(_("%s: %s will be permanently removed in Scilab %s.\n Please use %s instead.\n"), _("Warning"), "getURL", "2025.0.0", "http_get");
>       |     ^~~~~~~~~~
> cc1: some warnings being treated as errors
> make[4]: *** [Makefile:1798: sci_gateway/c/libscifileio_la-sci_getURL.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/scilab_2024.0.0+dfsg-5_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.