Bug#1066704: libcgns: FTBFS: tkogl.c:602:8: error: implicit declaration of function ‘TkWmAddToColormapWindows’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: libcgns
Version: 3.4.0-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/cgnstools/tkogl && /usr/bin/cc -DBUILD_HDF5 -DH5_BUILT_AS_STATIC_LIB -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src -I/<<PKGBUILDDIR>>/src -I/usr/include/hdf5/serial -I/usr/include/tcl -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -MD -MT src/cgnstools/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o -MF CMakeFiles/tkogl.dir/tkogl.c.o.d -o CMakeFiles/tkogl.dir/tkogl.c.o -c /<<PKGBUILDDIR>>/src/cgnstools/tkogl/tkogl.c
> /<<PKGBUILDDIR>>/src/cgnstools/tkogl/tkogl.c: In function ‘OGLwinCmd’:
> /<<PKGBUILDDIR>>/src/cgnstools/tkogl/tkogl.c:602:8: error: implicit declaration of function ‘TkWmAddToColormapWindows’ [-Werror=implicit-function-declaration]
>   602 |        TkWmAddToColormapWindows(tkwin);
>       |        ^~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[3]: *** [src/cgnstools/tkogl/CMakeFiles/tkogl.dir/build.make:79: src/cgnstools/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/libcgns_3.4.0-3_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.