Bug#1071144: qemu-web-desktop: move from dh-sysuser to standard dh_installsysusers

[Helmut Grohne]

Source: qemu-web-desktop
Version: 24.01.19+ds1-4
Severity: wishlist
Tags: patch

dh-sysuser is in operation for 7 years now and has gotten 8 users -
qemu-web-desktop being one of them. In that time, it didn't quite mature
and still has a number of deficiencies such as using useradd instead of
policy-recommended adduser or removing users on package removal against
project consensus for keeping users. I think it is time to call
dh-sysuser a failed experiment and move to the standard sysusers.d
mechanism used by many more packages. It has multiple implementations
now such that it does not force systemd onto installations anymore. Do
you agree with my reasoning? I'm attaching a patch for your convenience.

Helmut
-------------- next part --------------
diff -Nru qemu-web-desktop-24.01.19+ds1/debian/changelog qemu-web-desktop-24.01.19+ds1/debian/changelog
--- qemu-web-desktop-24.01.19+ds1/debian/changelog	2024-03-26 11:16:58.000000000 +0100
+++ qemu-web-desktop-24.01.19+ds1/debian/changelog	2024-05-15 07:58:04.000000000 +0200
@@ -1,3 +1,10 @@
+qemu-web-desktop (24.01.19+ds1-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Move from dh-sysuser to standard dh_installsysusers (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Wed, 15 May 2024 07:58:04 +0200
+
 qemu-web-desktop (24.01.19+ds1-4) unstable; urgency=medium
 
   * Add DARTS to the package description for better findability.
diff -Nru qemu-web-desktop-24.01.19+ds1/debian/control qemu-web-desktop-24.01.19+ds1/debian/control
--- qemu-web-desktop-24.01.19+ds1/debian/control	2024-03-26 11:06:00.000000000 +0100
+++ qemu-web-desktop-24.01.19+ds1/debian/control	2024-05-15 07:51:12.000000000 +0200
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian Science Maintainers <debian-science-maintainers at lists.alioth.debian.org>
 Uploaders: Roland Mas <lolando at debian.org>, Emmanuel Farhi <emmanuel.farhi at synchrotron-soleil.fr>, Fr?d?ric-Emmanuel Picca <picca at debian.org>
-Build-Depends: debhelper (>= 12), dh-apache2, dh-sysuser, pandoc
+Build-Depends: debhelper (>= 13.3), dh-apache2, pandoc
 Standards-Version: 4.1.2
 Vcs-Browser: https://salsa.debian.org/debian/qemu-web-desktop
 Vcs-Git: https://salsa.debian.org/debian/qemu-web-desktop.git
diff -Nru qemu-web-desktop-24.01.19+ds1/debian/rules qemu-web-desktop-24.01.19+ds1/debian/rules
--- qemu-web-desktop-24.01.19+ds1/debian/rules	2023-02-15 19:35:32.000000000 +0100
+++ qemu-web-desktop-24.01.19+ds1/debian/rules	2024-05-15 07:58:01.000000000 +0200
@@ -10,7 +10,7 @@
 
 
 %:
-	dh $@ --with apache2 --with sysuser
+	dh $@ --with apache2
 
 override_dh_auto_build:
 	mkdir build
@@ -21,6 +21,10 @@
 override_dh_install:
 	dh_install
 
+# Can be dropped in compat level 14
+execute_after_dh_installinit:
+	dh_installsysusers
+
 override_dh_clean:
 	rm -rf build
 	dh_clean
diff -Nru qemu-web-desktop-24.01.19+ds1/debian/sysuser qemu-web-desktop-24.01.19+ds1/debian/sysuser
--- qemu-web-desktop-24.01.19+ds1/debian/sysuser	2023-02-15 19:35:32.000000000 +0100
+++ qemu-web-desktop-24.01.19+ds1/debian/sysuser	1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-_qemu-web-desktop home=/var/lib/qemu-web-desktop
diff -Nru qemu-web-desktop-24.01.19+ds1/debian/sysusers qemu-web-desktop-24.01.19+ds1/debian/sysusers
--- qemu-web-desktop-24.01.19+ds1/debian/sysusers	1970-01-01 01:00:00.000000000 +0100
+++ qemu-web-desktop-24.01.19+ds1/debian/sysusers	2024-05-15 07:56:22.000000000 +0200
@@ -0,0 +1 @@
+u	_qemu-web-desktop	-	-	/var/lib/qemu-web-desktop