Bug#1087772: grads: FTBFS with HDF5 1.14: too few arguments to function ‘H5Oget_info3’

[Gilles Filippini]

Source: grads
Version: 3:2.2.1-8
Severity: important
Tags: ftbfs patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

During a test rebuild against HDF5 1.14 currently in experimental grads FTBFS with:

gcc -DHAVE_CONFIG_H -I.  -I. -I/usr/include   -I/usr/include/hdf  -I/usr/include/hdf5/serial -I/usr/include/geotiff     -I/usr/include/hdf  -I/usr/include   -g -O2 -Werror=i
mplicit-function-declaration -ffile-prefix-map=/build/grads-flY8KZ/grads-2.2.1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-prot
ection -fPIC -rdynamic -c -o gaio.o gaio.c
In file included from /usr/include/hdf5/serial/H5public.h:31,
                 from /usr/include/hdf5/serial/hdf5.h:21,
                 from grads.h:13,
                 from gaio.c:19:
gaio.c: In function ‘h5pattrs’:
/usr/include/hdf5/serial/H5version.h:921:23: error: too few arguments to function ‘H5Oget_info3’
  921 |   #define H5Oget_info H5Oget_info3
      |                       ^~~~~~~~~~~~
gaio.c:4699:15: note: in expansion of macro ‘H5Oget_info’
 4699 |     if ((rc = H5Oget_info(vid,&oinfo))<0) err=1;
      |               ^~~~~~~~~~~
In file included from /usr/include/hdf5/serial/H5Apublic.h:21,
                 from /usr/include/hdf5/serial/hdf5.h:22:
/usr/include/hdf5/serial/H5Opublic.h:506:15: note: declared here
  506 | H5_DLL herr_t H5Oget_info3(hid_t loc_id, H5O_info2_t *oinfo, unsigned fields);
      |               ^~~~~~~~~~~~
make[3]: *** [Makefile:802: gaio.o] Error 1


Please find attached a patch proposal.

Best,
_g.

- -- System Information:
Debian Release: 12.0
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-26-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEoJObzArDE05WtIyR7+hsbH/+z4MFAmc7T/8ACgkQ7+hsbH/+
z4NjCQf+PrKCmshOEZMcbxFbZpvwooJChEGknP5e14N4ai3ekPDCnYPGL5mg20Aa
vVSXEtwCpCw3XaI+CKxW/MG7qqpGaJHfhLJ6eOcfMfQf3SmiWeXPBY+UHHU3vvDq
nmcoAztS5nwlPOQ4/2xkT3uIYn62qfrz0XAt8XJSMbNdrc9gi8JZOM3pRsCFcVrw
F6t17z1wOvyjjcBCI+V4IBvXbFtM4xAgSAsxFH0SSyDfb4PnXNkmnBdnSp9v1rql
cQdRNmdvUZzL4FSmyEmv8FlpF54tuXGbom1FUTl0gSF+E06RwyDgt6QS3eYgFcZ/
/UOPHCZDt722NNDpQHG7FAvKWJOarw==
=obC5
-----END PGP SIGNATURE-----
-------------- next part --------------
diff -Nru grads-2.2.1/debian/changelog grads-2.2.1/debian/changelog
--- grads-2.2.1/debian/changelog	2024-09-16 09:15:50.000000000 +0200
+++ grads-2.2.1/debian/changelog	2024-11-17 21:43:25.000000000 +0100
@@ -1,3 +1,10 @@
+grads (3:2.2.1-8.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Add -DH5_USE_110_API to CFLAGS to fix FTBFS against HDF5-1.14
+
+ -- Gilles Filippini <pini at debian.org>  Sun, 17 Nov 2024 21:43:25 +0100
+
 grads (3:2.2.1-8) unstable; urgency=medium
 
   * Temporarily drop libsx support. Closes: #1080994
diff -Nru grads-2.2.1/debian/rules grads-2.2.1/debian/rules
--- grads-2.2.1/debian/rules	2024-09-16 09:15:50.000000000 +0200
+++ grads-2.2.1/debian/rules	2024-11-17 21:43:25.000000000 +0100
@@ -12,7 +12,8 @@
 include /usr/share/dpkg/buildflags.mk
 
 CFLAGS:=$(shell dpkg-buildflags --get CFLAGS) \
-	-fPIC
+	-fPIC \
+	-DH5_USE_110_API
 
 CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS) \
 	-I/usr/include/cairo  \