Bug#1083127: opencascade FTBFS: error: invalid conversion from ‘unsigned char*’ to ‘const char*’ [-fpermissive]

[Tobias Frost]

On Wed, Oct 02, 2024 at 07:16:18PM +0200, Santiago Vila wrote:
> El 2/10/24 a las 7:44, Francesco Ballarin escribió:
> > FYI, I am reasonably sure that
> > https://github.com/Open-Cascade-SAS/OCCT/commit/7236e83dcc1e7284e66dc61e612154617ef715d6.patch
> > will fix the issue.
> 
> Great. I've converted the above patch to Debian form (see attach).
> (but it's untested yet).
> 
> Tobias: Can you handle this as the usual uploader?
> 
> Or maybe it would help if I make a "team upload"?

I can handle it tomorrow, but be very welcome to do an team upload as well!

Cheers,
tobi

> Thanks.

> commit e16744ea146ef4a39fe2f3c0f7b4dfb3ad14be95
> Author: Santiago Vila <sanvila at debian.org>
> Date:   Wed Oct 2 15:05:00 2024 +0200
> 
>     Use auto instead of specific type. Closes: #1083127.
> 
> diff --git a/debian/patches/0013-use-auto-instead-of-specific-type.patch b/debian/patches/0013-use-auto-instead-of-specific-type.patch
> new file mode 100644
> index 000000000..aa18f6187
> --- /dev/null
> +++ b/debian/patches/0013-use-auto-instead-of-specific-type.patch
> @@ -0,0 +1,20 @@
> +From: dpasukhi <dpasukhi at opencascade.com>
> +Subject: [PATCH] 0033808: Coding - FreeType Use unsigned point and contour indexing in `FT_Outline`
> +Bug-Debian: https://bugs.debian.org/1083127
> +
> +Changes to auto instead of specific type
> +---
> + src/StdPrs/StdPrs_BRepFont.cxx | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +--- a/src/StdPrs/StdPrs_BRepFont.cxx
> ++++ b/src/StdPrs/StdPrs_BRepFont.cxx
> +@@ -457,7 +457,7 @@
> +   for (short aContour = 0, aStartIndex = 0; aContour < anOutline->n_contours; ++aContour)
> +   {
> +     const FT_Vector* aPntList = &anOutline->points[aStartIndex];
> +-    const char* aTags      = &anOutline->tags[aStartIndex];
> ++    const auto* aTags      = &anOutline->tags[aStartIndex];
> +     const short anEndIndex = anOutline->contours[aContour];
> +     const short aPntsNb    = (anEndIndex - aStartIndex) + 1;
> +     aStartIndex = anEndIndex + 1;
> diff --git a/debian/patches/series b/debian/patches/series
> index 6e3d95104..054544d09 100644
> --- a/debian/patches/series
> +++ b/debian/patches/series
> @@ -12,3 +12,4 @@ do-not-use-doxygen-searchengine.patch
>  0010-fix-cmake-module.patch
>  0011-cmake-workaround-tbbmemory.patch
>  0012-cmake-do-not-export-ffile-prefix.patch
> +0013-use-auto-instead-of-specific-type.patch