Bug#1082562: dyssol: FTBFS build fails with sundials 7

[Drew Parsons]

Source: dyssol
Version: 1.1.1+ds1-2.1
Severity: important
Tags: ftbfs
Control: forwarded -1 https://github.com/DyssolTEC/Dyssol-open/issues/188

dyssol fails to build against sundials 7 (in experimental)

We'll want to upload sundials 7 soon to unstable (transition
#1082552), at which point this bug would become Severity: serious.


One thing to note is that MPI support (when enabled) is now in
sundials core, not only in the sundials parallel components, because
of SUNComm. When building dyssol against MPI-enabled sundials 7, there
will be a compilation error via sundials_matrix.h included in
DAESolver.h, sundials_types.h:57:10: fatal error: mpi.h: No such file
or directory. This can be easily worked around by using mpi compilers,
CXX=mpicxx

Then, ida_impl.h is no longer provided in /usr/include/ida, so

[ 12%] Building CXX object CMakeFiles/libdyssol_shared.dir/EquationSolvers/NLSolver.cpp.o
/usr/bin/mpicxx -DGRAPHVIZ -DINSTALL_DOCS_PATH=\"/usr/share/Dyssol/docs\" -Dlibdyssol_shared_EXPORTS -I/projects/misc/build/dyssol-1.1.1+ds1/BaseSolvers -I/projects/misc/build/dyssol-1.1.1+ds1/CacheHandler -I/projects/misc/build/dyssol-1.1.1+ds1/EquationSolvers -I/projects/misc/build/dyssol-1.1.1+ds1/HDF5Handler -I/projects/misc/build/dyssol-1.1.1+ds1/MaterialsDatabase -I/projects/misc/build/dyssol-1.1.1+ds1/ModelsAPI -I/projects/misc/build/dyssol-1.1.1+ds1/Modules -I/projects/misc/build/dyssol-1.1.1+ds1/ScriptInterface -I/projects/misc/build/dyssol-1.1.1+ds1/SimulatorCore -I/projects/misc/build/dyssol-1.1.1+ds1/Utilities -I/projects/misc/build/dyssol-1.1.1+ds1/Modules/DustFormationTester -I/usr/include/hdf5/serial -I/usr/include/sundials -I/usr/include/graphviz -g -O2 -ffile-prefix-map=/projects/misc/build/dyssol-1.1.1+ds1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -fPIC -MD -MT CMakeFiles/libdyssol_shared.dir/EquationSolvers/NLSolver.cpp.o -MF CMakeFiles/libdyssol_shared.dir/EquationSolvers/NLSolver.cpp.o.d -o CMakeFiles/libdyssol_shared.dir/EquationSolvers/NLSolver.cpp.o -c /projects/misc/build/dyssol-1.1.1+ds1/EquationSolvers/NLSolver.cpp
/projects/misc/build/dyssol-1.1.1+ds1/EquationSolvers/DAESolver.cpp:9:10: fatal error: ida/ida_impl.h: No such file or directory
    9 | #include <ida/ida_impl.h>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [CMakeFiles/libdyssol_shared.dir/build.make:163: CMakeFiles/libdyssol_shared.dir/EquationSolvers/DAESolver.cpp.o] Error 1


Thirdly, realtype does not get defined

[  6%] Building CXX object CMakeFiles/libdyssol_static.dir/BaseSolvers/BaseSolver.cpp.o
/usr/bin/mpicxx -DGRAPHVIZ -DINSTALL_DOCS_PATH=\"/usr/share/Dyssol/docs\" -I/projects/misc/build/dyssol-1.1.1+ds1/BaseSolvers -I/projects/misc/build/dyssol-1.1.1+ds1/CacheHandler -I/projects/misc/build/dyssol-1.1.1+ds1/EquationSolvers -I/projects/misc/build/dyssol-1.1.1+ds1/HDF5Handler -I/projects/misc/build/dyssol-1.1.1+ds1/MaterialsDatabase -I/projects/misc/build/dyssol-1.1.1+ds1/ModelsAPI -I/projects/misc/build/dyssol-1.1.1+ds1/Modules -I/projects/misc/build/dyssol-1.1.1+ds1/ScriptInterface -I/projects/misc/build/dyssol-1.1.1+ds1/SimulatorCore -I/projects/misc/build/dyssol-1.1.1+ds1/Utilities -I/projects/misc/build/dyssol-1.1.1+ds1/Modules/DustFormationTester -I/usr/include/hdf5/serial -I/usr/include/sundials -I/usr/include/graphviz -g -O2 -ffile-prefix-map=/projects/misc/build/dyssol-1.1.1+ds1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -MD -MT CMakeFiles/libdyssol_static.dir/BaseSolvers/BaseSolver.cpp.o -MF CMakeFiles/libdyssol_static.dir/BaseSolvers/BaseSolver.cpp.o.d -o CMakeFiles/libdyssol_static.dir/BaseSolvers/BaseSolver.cpp.o -c /projects/misc/build/dyssol-1.1.1+ds1/BaseSolvers/BaseSolver.cpp
In file included from /projects/misc/build/dyssol-1.1.1+ds1/ModelsAPI/UnitDevelopmentDefines.h:6,
                 from /projects/misc/build/dyssol-1.1.1+ds1/Units/Bunker/Bunker.h:5,
                 from /projects/misc/build/dyssol-1.1.1+ds1/Units/Bunker/Bunker.cpp:4:
/projects/misc/build/dyssol-1.1.1+ds1/EquationSolvers/DAESolver.h:32:29: error: ‘realtype’ was not declared in this scope; did you mean ‘decltype’?
   32 |                 std::vector<realtype> vars;
      |                             ^~~~~~~~
      |                             decltype
/projects/misc/build/dyssol-1.1.1+ds1/EquationSolvers/DAESolver.h:32:37: error: template argument 1 is invalid
   32 |                 std::vector<realtype> vars;
      |                                     ^
/projects/misc/build/dyssol-1.1.1+ds1/EquationSolvers/DAESolver.h:32:37: error: template argument 2 is invalid
In file included from /projects/misc/build/dyssol-1.1.1+ds1/ModelsAPI/UnitDevelopmentDefines.h:6,
                 from /projects/misc/build/dyssol-1.1.1+ds1/Units/Crusher/Crusher.h:5,
                 from /projects/misc/build/dyssol-1.1.1+ds1/Units/Crusher/Crusher.cpp:4: