Bug#1122139: armadillo FTCBFS: fails tests despite DEB_BUILD_OPTIONS containing nocheck

[Helmut Grohne]

Source: armadillo
Version: 1:15.2.1+dfsg-2
Tags: patch
User: debian-cross at lists.debian.org
Usertags: ftcbfs

armadillo regressed cross building, because it gained tests. Now those
tests are being run and fail even when DEB_BUILD_OPTIONS contains
nocheck. Testing is great, but it cannot happen in real cross builds.
I'm attaching that adds nocheck support and once adding it, armadillo
cross builds successfully again. Please consider applying it.

Helmut
-------------- next part --------------
diff -Nru armadillo-15.2.1+dfsg/debian/changelog armadillo-15.2.1+dfsg/debian/changelog
--- armadillo-15.2.1+dfsg/debian/changelog	2025-11-06 05:15:34.000000000 +0100
+++ armadillo-15.2.1+dfsg/debian/changelog	2025-12-06 22:06:12.000000000 +0100
@@ -1,3 +1,10 @@
+armadillo (1:15.2.1+dfsg-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Honour DEB_BUILD_OPTIONS=nocheck. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sat, 06 Dec 2025 22:06:12 +0100
+
 armadillo (1:15.2.1+dfsg-2) unstable; urgency=medium
 
   * Upload to unstable
diff -Nru armadillo-15.2.1+dfsg/debian/rules armadillo-15.2.1+dfsg/debian/rules
--- armadillo-15.2.1+dfsg/debian/rules	2025-11-06 05:15:26.000000000 +0100
+++ armadillo-15.2.1+dfsg/debian/rules	2025-12-06 22:06:12.000000000 +0100
@@ -17,10 +17,12 @@
 
 build-stamp:
 	dh_testdir
-	dh_auto_configure --buildsystem=cmake --builddirectory=. -- -D INSTALL_LIB_DIR=lib -D CMAKE_INpppSTALL_PREFIX_INITIALIZED_TO_DEFAULT:BOOL=ON  . # specified to install to the debian/tmp directory.
+	dh_auto_configure --buildsystem=cmake --builddirectory=. -- -D INSTALL_LIB_DIR=lib -D CMAKE_INpppSTALL_PREFIX_INITIALIZED_TO_DEFAULT:BOOL=ON -DBUILD_SMOKE_TEST=$(if $(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)),OFF,ON) . # specified to install to the debian/tmp directory.
 	$(MAKE)
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)),)
 	cd tests1 && LD_LIBRARY_PATH=.. ./smoke_test && cd ..
 	cd tests2 && $(MAKE) && LD_LIBRARY_PATH=.. ./main && cd ..
+endif
 	touch $@
 
 clean: