Bug#1122401: cvc5: FTBFS: /<<PKGBUILDDIR>>/src/prop/cadical.cpp:88:8: error: 'void cvc5::internal::prop::CadicalPropagator::notify_assignment(int, bool)' marked 'override', but does not override

[Santiago Vila]

Package: src:cvc5
Version: 1.1.2-3
Severity: serious
Tags: ftbfs forky sid

Dear maintainer:

During a rebuild of all packages in unstable, this package failed to build.

Below you will find the last part of the build log (probably the most
relevant part, but not necessarily). If required, the full build log
is available here:

https://people.debian.org/~sanvila/build-logs/202512/

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you cannot reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and add an affects on src:cvc5, so that this is still
visible in the BTS web page for this package.

Thanks.

--------------------------------------------------------------------------------
[...]
[ 20%] Building CXX object src/CMakeFiles/cvc5-obj.dir/proof/alethe/alethe_proof_rule.cpp.o
cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src && /usr/bin/c++ [too-long-redacted] of/alethe/alethe_proof_rule.cpp
[ 20%] Building CXX object src/CMakeFiles/cvc5-obj.dir/prop/cadical.cpp.o
cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src && /usr/bin/c++ [too-long-redacted] BUILDDIR>>/src/prop/cadical.cpp
/<<PKGBUILDDIR>>/src/prop/cadical.cpp:88:8: error: ‘void cvc5::internal::prop::CadicalPropagator::notify_assignment(int, bool)’ marked ‘override’, but does not override
   88 |   void notify_assignment(int lit, bool is_fixed) override
      |        ^~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/prop/cadical.cpp:485:8: error: ‘bool cvc5::internal::prop::CadicalPropagator::cb_has_external_clause()’ marked ‘override’, but does not override
  485 |   bool cb_has_external_clause() override { return !d_new_clauses.empty(); }
      |        ^~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/prop/cadical.cpp: In member function ‘virtual void cvc5::internal::prop::CadicalSolver::initialize(cvc5::context::Context*, cvc5::internal::prop::TheoryProxy*, cvc5::context::UserContext*, cvc5::internal::prop::PropPfManager*)’:
/<<PKGBUILDDIR>>/src/prop/cadical.cpp:1175:75: error: invalid new-expression of abstract class type ‘cvc5::internal::prop::CadicalPropagator’
 1175 |   d_propagator.reset(new CadicalPropagator(theoryProxy, context, *d_solver));
      |                                                                           ^
/<<PKGBUILDDIR>>/src/prop/cadical.cpp:68:7: note:   because the following virtual functions are pure within ‘cvc5::internal::prop::CadicalPropagator’:
   68 | class CadicalPropagator : public CaDiCaL::ExternalPropagator
      |       ^~~~~~~~~~~~~~~~~
In file included from /<<PKGBUILDDIR>>/src/./prop/cadical.h:23,
                 from /<<PKGBUILDDIR>>/src/prop/cadical.cpp:18:
/usr/include/cadical.hpp:1178:16: note:     ‘virtual void CaDiCaL::ExternalPropagator::notify_assignment(const std::vector<int>&)’
 1178 |   virtual void notify_assignment (const std::vector<int> &lits) = 0;
      |                ^~~~~~~~~~~~~~~~~
/usr/include/cadical.hpp:1253:16: note:     ‘virtual bool CaDiCaL::ExternalPropagator::cb_has_external_clause(bool&)’
 1253 |   virtual bool cb_has_external_clause (bool &is_forgettable) = 0;
      |                ^~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/prop/cadical.cpp: In member function ‘virtual cvc5::internal::ClauseId cvc5::internal::prop::CadicalSolver::addXorClause(cvc5::internal::prop::SatClause&, bool, bool)’:
/<<PKGBUILDDIR>>/src/prop/cadical.cpp:1093:20: warning: control reaches end of non-void function [-Wreturn-type]
 1093 |   Unreachable() << "CaDiCaL does not support adding XOR clauses.";
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/prop/cadical.cpp: In member function ‘virtual cvc5::internal::prop::SatValue cvc5::internal::prop::CadicalSolver::solve(long unsigned int&)’:
/<<PKGBUILDDIR>>/src/prop/cadical.cpp:1114:22: warning: control reaches end of non-void function [-Wreturn-type]
 1114 |   Unimplemented() << "Setting limits for CaDiCaL not supported yet";
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [src/CMakeFiles/cvc5-obj.dir/build.make:1608: src/CMakeFiles/cvc5-obj.dir/prop/cadical.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:826: src/CMakeFiles/cvc5-obj.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:149: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j2 INSTALL="install --strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:18: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------