Bug#1122627: cadical: FTBFS on riscv64 due to test timeout

[Aurelien Jarno]

Source: cadical
Version: 2.1.3-1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: debian-riscv at lists.debian.org
User: debian-riscv at lists.debian.org
Usertags: riscv64

Dear maintainer,

cadical fails to build from source on riscv64 with a timeout in one test:

| test/api/run.sh: using CXX=g++
| test/api/run.sh: using CXXFLAGS=-g -O2 -ffile-prefix-map=/build/reproducible-path/cadical-2.1.3=. -fstack-protector-strong -Wformat -Werror=format-security -DNBUILD -fPIC -Wall -Wextra -O3 -DNDEBUG
| test/api/run.sh: using CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2
| test/api/run.sh: using LDFLAGS=-Wl,-z,relro -Wl,-z,now
| test/api/run.sh: running API test 'parcompwrite'
| g++ -g -O2 -ffile-prefix-map=/build/reproducible-path/cadical-2.1.3=. -fstack-protector-strong -Wformat -Werror=format-security -DNBUILD -fPIC -Wall -Wextra -O3 -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -o ../build/test-api-parcompwrite.o -c ../test/api/parcompwrite.cpp
| g++ -g -O2 -ffile-prefix-map=/build/reproducible-path/cadical-2.1.3=. -fstack-protector-strong -Wformat -Werror=format-security -DNBUILD -fPIC -Wall -Wextra -O3 -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -o ../build/test-api-parcompwrite ../build/test-api-parcompwrite.o -Wl,-z,relro -Wl,-z,now -L../build -lcadical
| ../build/test-api-parcompwrite
| error: unexpected alarm (file I/O hanging?)
| # 0 ... failed (non-zero exit code)

...

| test/api/run.sh: API testing results: 15 ok, 1 failed
| make[3]: *** [makefile:3: api] Error 1
| make[3]: Leaving directory '/build/reproducible-path/cadical-2.1.3/test'
| make[2]: *** [makefile:103: test] Error 2
| make[2]: Leaving directory '/build/reproducible-path/cadical-2.1.3/build'
| make[1]: *** [makefile:17: test] Error 2
| make[1]: Leaving directory '/build/reproducible-path/cadical-2.1.3'
| dh_auto_test: error: make -j4 test TESTSUITEFLAGS="-j4 --verbose" VERBOSE=1 returned exit code 2
| make: *** [debian/rules:12: binary-arch] Error 25
| dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit status 2

The full build log is available here:
https://buildd.debian.org/status/fetch.php?pkg=cadical&arch=riscv64&ver=2.1.3-1&stamp=1765299510&raw=0

It appears that the new test-api-parcompwrite test contains a timeout,
which is too low for riscv64 (and hppa). The following patch fixes that
by increasing it from 1 to 2 seconds:

--- cadical-2.1.3.orig/test/api/parcompwrite.cpp
+++ cadical-2.1.3/test/api/parcompwrite.cpp
@@ -248,7 +248,7 @@ static void catch_alarm (int sig) {
 int main () {
   const char *suffixes[] = {"", ".gz"};
   (void) ::signal (SIGALRM, catch_alarm);
-  ::alarm (1);
+  ::alarm (2);
   for (auto s : suffixes) {
     suffix = s;
     for (unsigned c = 0; c != 2; c++) {

Regards
Aurelien