Bug#1096768: grads: ftbfs with GCC-15

[Matthias Klose]

Package: src:grads
Version: 3:2.2.1-9
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/grads_2.2.1-9_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
gxcntr.c:24:6: note: declared here
   24 | void gree();
      |      ^~~~
gxcntr.c:1015:4: error: too many arguments to function ‘gree’; expected 0, have 2
 1015 |    gree (pclbuf,"c6");
      |    ^~~~  ~~~~~~
gxcntr.c:24:6: note: declared here
   24 | void gree();
      |      ^~~~
gxcntr.c: In function ‘gxcrel’:
gxcntr.c:1093:5: error: too many arguments to function ‘gree’; expected 0, have 2
 1093 |     gree (lwk,"c7"); lwk = NULL;
      |     ^~~~  ~~~
gxcntr.c:24:6: note: declared here
   24 | void gree();
      |      ^~~~
gxcntr.c:1096:5: error: too many arguments to function ‘gree’; expected 0, have 2
 1096 |     gree (fwk,"c8"); fwk = NULL;
      |     ^~~~  ~~~
gxcntr.c:24:6: note: declared here
   24 | void gree();
      |      ^~~~
make[3]: *** [Makefile:798: gxcntr.o] Error 1
grads.c: In function ‘main’:
grads.c:319:21: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  319 |   signal(CPULIMSIG, gasigcpu) ;  /* CPU time limit signal; just exit */
      |                     ^~~~~~~~
      |                     |
      |                     void (*)(void)
In file included from grads.c:35:
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void (*)(int)’} but argument is of type ‘void (*)(void)’
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
grads.c:86:8: note: ‘gasigcpu’ declared here
   86 |   void gasigcpu() ;
      |        ^~~~~~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
grads.c: In function ‘gainit’:
grads.c:456:25: error: too many arguments to function ‘gree’; expected 0, have 2
  456 |     if (gcmn.mpdset[i]) gree(gcmn.mpdset[i],"g1");
      |                         ^~~~ ~~~~~~~~~~~~~~
In file included from grads.c:36:
grads.h:1305:6: note: declared here
 1305 | void gree();
      |      ^~~~
grads.c: At top level:
grads.c:638:6: error: conflicting types for ‘gasigcpu’; have ‘void(gaint)’ {aka ‘void(int)’}
  638 | void gasigcpu(gaint i) {
      |      ^~~~~~~~
grads.c:86:8: note: previous declaration of ‘gasigcpu’ with type ‘void(void)’
   86 |   void gasigcpu() ;
      |        ^~~~~~~~
grads.c: In function ‘gaudpdef’:
grads.c:797:32: error: too many arguments to function ‘gree’; expected 0, have 2
  797 |     if (pass>0 && cname!=NULL) gree(cname,"f306");
      |                                ^~~~ ~~~~~
grads.h:1305:6: note: declared here
 1305 | void gree();
      |      ^~~~
make[3]: *** [Makefile:798: grads.o] Error 1
make[3]: Leaving directory '/build/reproducible-path/grads-2.2.1/src'
make[2]: *** [Makefile:623: all] Error 2
make[2]: Leaving directory '/build/reproducible-path/grads-2.2.1/src'
make[1]: *** [Makefile:474: all-recursive] Error 1
make[1]: Leaving directory '/build/reproducible-path/grads-2.2.1'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:5: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2