Bug#1097387: metview: ftbfs with GCC-15

Mon Feb 17 17:37:27 GMT 2025

Package: src:metview
Version: 5.23.1-1
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/metview_5.23.1-1_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
/build/reproducible-path/metview-5.23.1/mars-client/src/tools.c:1203:28: warning: '__builtin___sprintf_chk' may write a terminating nul past the end of the destination [-Wformat-overflow=]
 1203 |         sprintf(tmp, "%s/%s", dir, fname);
      |                            ^
In function 'sprintf',
    inlined from 'real_name' at /build/reproducible-path/metview-5.23.1/mars-client/src/tools.c:1203:9:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: '__builtin___sprintf_chk' output 2 or more bytes (assuming 1025) into a destination of size 1024
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
[ 32%] Building C object mars-client/src/CMakeFiles/marsclient.dir/marsxdr.c.o
cd /build/reproducible-path/metview-5.23.1/debian/build/mars-client/src && /usr/bin/cc -DLITTLE_END -DNOFDB -DODB_SUPPORT -DR64 -Dmarsclient_EXPORTS -I/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src -I/build/reproducible-path/metview-5.23.1/mars-client/src -I/build/reproducible-path/metview-5.23.1/mir/src -I/build/reproducible-path/metview-5.23.1/debian/build/mir/src -I/usr/include/tirpc -I/usr/include/x86_64-linux-gnu/eckit/linalg -I/usr/include/x86_64-linux-gnu/eckit -I/usr/include/x86_64-linux-gnu/eckit/geometry -I/usr/include/x86_64-linux-gnu/eckit/option -I/usr/include/x86_64-linux-gnu/odc -I/usr/include/x86_64-linux-gnu/eckit/sql -I/usr/include/x86_64-linux-gnu/metkit -I/usr/include/x86_64-linux-gnu/fdb5 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/metview-5.23.1=. -fstack-protector-strong -fstack-clash-protection -fcf-protection -Wall -pedantic -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -pipe -O3 -DNDEBUG -fPIC -MD -MT mars-client/src/CMakeFiles/marsclient.dir/marsxdr.c.o -MF CMakeFiles/marsclient.dir/marsxdr.c.o.d -o CMakeFiles/marsclient.dir/marsxdr.c.o -c /build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c
[ 32%] Building C object mars-client/src/CMakeFiles/marsclient.dir/mars_client_version.c.o
cd /build/reproducible-path/metview-5.23.1/debian/build/mars-client/src && /usr/bin/cc -DLITTLE_END -DNOFDB -DODB_SUPPORT -DR64 -Dmarsclient_EXPORTS -I/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src -I/build/reproducible-path/metview-5.23.1/mars-client/src -I/build/reproducible-path/metview-5.23.1/mir/src -I/build/reproducible-path/metview-5.23.1/debian/build/mir/src -I/usr/include/tirpc -I/usr/include/x86_64-linux-gnu/eckit/linalg -I/usr/include/x86_64-linux-gnu/eckit -I/usr/include/x86_64-linux-gnu/eckit/geometry -I/usr/include/x86_64-linux-gnu/eckit/option -I/usr/include/x86_64-linux-gnu/odc -I/usr/include/x86_64-linux-gnu/eckit/sql -I/usr/include/x86_64-linux-gnu/metkit -I/usr/include/x86_64-linux-gnu/fdb5 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/metview-5.23.1=. -fstack-protector-strong -fstack-clash-protection -fcf-protection -Wall -pedantic -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -pipe -O3 -DNDEBUG -fPIC -MD -MT mars-client/src/CMakeFiles/marsclient.dir/mars_client_version.c.o -MF CMakeFiles/marsclient.dir/mars_client_version.c.o.d -o CMakeFiles/marsclient.dir/mars_client_version.c.o -c /build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/mars_client_version.c
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c: In function 'xdr_cache_t':
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:13:15: error: conflicting types for 'strcache'; have 'char *(void)'
   13 |  extern char* strcache();
      |               ^~~~~~~~
In file included from /build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/rpcmars.h:21,
                 from /build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:6:
/build/reproducible-path/metview-5.23.1/mars-client/src/hash.h:20:7: note: previous declaration of 'strcache' with type 'char *(const char *)'
   20 | char* strcache(const char* name);
      |       ^~~~~~~~
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:34:10: error: too many arguments to function 'strcache'; expected 0, have 1
   34 |  *name = strcache(sp);
      |          ^~~~~~~~ ~~
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:13:15: note: declared here
   13 |  extern char* strcache();
      |               ^~~~~~~~
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c: In function 'xdr_value':
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:47:27: warning: unused variable 'buf' [-Wunused-variable]
   47 |         register int32_t *buf;
      |                           ^~~
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c: In function 'xdr_request':
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:63:27: warning: unused variable 'buf' [-Wunused-variable]
   63 |         register int32_t *buf;
      |                           ^~~
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c: In function 'xdr_parameter':
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:83:27: warning: unused variable 'buf' [-Wunused-variable]
   83 |         register int32_t *buf;
      |                           ^~~
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c: In function 'xdr_netlock':
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:206:27: warning: unused variable 'buf' [-Wunused-variable]
  206 |         register int32_t *buf;
      |                           ^~~
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c: In function 'xdr_cache_index':
/build/reproducible-path/metview-5.23.1/debian/build/mars-client/src/marsxdr.c:218:27: warning: unused variable 'buf' [-Wunused-variable]
  218 |         register int32_t *buf;
      |                           ^~~
make[3]: *** [mars-client/src/CMakeFiles/marsclient.dir/build.make:1267: mars-client/src/CMakeFiles/marsclient.dir/marsxdr.c.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In function 'netcdf_attribute_to_request',
    inlined from 'netcdf_schema_to_request' at /build/reproducible-path/metview-5.23.1/mars-client/src/ncschema.c:494:25:
/build/reproducible-path/metview-5.23.1/mars-client/src/ncschema.c:367:21: warning: 'd' may be used uninitialized [-Wmaybe-uninitialized]
  367 |                     mars_field_index_add(idx, c->name, s_ok, buf, l_ok, l, d_ok, d);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/reproducible-path/metview-5.23.1/mars-client/src/ncschema.c: In function 'netcdf_schema_to_request':
/build/reproducible-path/metview-5.23.1/mars-client/src/ncschema.c:324:16: note: 'd' was declared here
  324 |         double d;
      |                ^
make[3]: Leaving directory '/build/reproducible-path/metview-5.23.1/debian/build'
make[2]: *** [CMakeFiles/Makefile2:5293: mars-client/src/CMakeFiles/marsclient.dir/all] Error 2
make[2]: Leaving directory '/build/reproducible-path/metview-5.23.1/debian/build'
make[1]: *** [Makefile:169: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/metview-5.23.1/debian/build'
dh_auto_build: error: cd debian/build && make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:53: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2