Bug#1097915: spd: ftbfs with GCC-15

[Matthias Klose]

Package: src:spd
Version: 1.3.0-1.1
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/spd_1.3.0-1.1_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
spd.h:596:12: warning: ‘maxhdkey’ defined but not used [-Wunused-variable]
  596 | static int maxhdkey = sizeof(headkey) / sizeof(char *);
      |            ^~~~~~~~
util.c:205:35: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ [-Wformat=]
  205 |     printf("           size %3s: %d\n"," ",loop_ptr->size);
      |                                  ~^        ~~~~~~~~~~~~~~
      |                                   |                |
      |                                   int              long int
      |                                  %ld
spd.h:421:14: warning: ‘typestr’ defined but not used [-Wunused-variable]
  421 | static char *typestr[] = {"invalid","source","corrected","dark","floodfield",
      |              ^~~~~~~
inout.c: In function ‘main’:
inout.c:1533:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1533 |         fgets(buf,2048, stdin);
      |         ^~~~~~~~~~~~~~~~~~~~~~
util.c: At top level:
util.c:237:5: error: conflicting types for ‘byte_swap2N’; have ‘int(union swap2_data *, int)’
  237 | int byte_swap2N(register union swap2_data *s,int n)
      |     ^~~~~~~~~~~
In file included from util.c:76:
spd.h:757:5: note: previous declaration of ‘byte_swap2N’ with type ‘int(void)’
  757 | int byte_swap2N();
      |     ^~~~~~~~~~~
correct.c: In function ‘spd_calcspline’:
correct.c:822:16: error: too many arguments to function ‘bispev_’; expected 0, have 17
  822 | #define BISPEV bispev_
      |                ^~~~~~~
correct.c:1148:3: note: in expansion of macro ‘BISPEV’
 1148 |   BISPEV(spline->xlambda,&spline->dx_xknots,spline->xmu,&spline->dx_yknots,
      |   ^~~~~~
correct.c:823:6: note: declared here
  823 | void bispev_();
      |      ^~~~~~~
correct.c:822:16: error: too many arguments to function ‘bispev_’; expected 0, have 17
  822 | #define BISPEV bispev_
      |                ^~~~~~~
correct.c:1165:3: note: in expansion of macro ‘BISPEV’
 1165 |   BISPEV(spline->ylambda,&spline->dy_xknots,spline->ymu,&spline->dy_yknots,
      |   ^~~~~~
correct.c:823:6: note: declared here
  823 | void bispev_();
      |      ^~~~~~~
util.c: In function ‘print_memlist’:
util.c:209:1: warning: control reaches end of non-void function [-Wreturn-type]
  209 | }
      | ^
spd.h: At top level:
spd.h:596:12: warning: ‘maxhdkey’ defined but not used [-Wunused-variable]
  596 | static int maxhdkey = sizeof(headkey) / sizeof(char *);
      |            ^~~~~~~~
spd.h:421:14: warning: ‘typestr’ defined but not used [-Wunused-variable]
  421 | static char *typestr[] = {"invalid","source","corrected","dark","floodfield",
      |              ^~~~~~~
make[3]: *** [Makefile:384: util.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from correct.c:756:
spd.h: At top level:
spd.h:596:12: warning: ‘maxhdkey’ defined but not used [-Wunused-variable]
  596 | static int maxhdkey = sizeof(headkey) / sizeof(char *);
      |            ^~~~~~~~
make[3]: *** [Makefile:384: correct.o] Error 1
make[3]: Leaving directory '/build/reproducible-path/spd-1.3.0/src'
make[2]: *** [Makefile:373: all-recursive] Error 1
make[2]: Leaving directory '/build/reproducible-path/spd-1.3.0'
make[1]: *** [Makefile:314: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/spd-1.3.0'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:9: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2