Bug#1098141: xgks: ftbfs with GCC-15

[Matthias Klose]

Package: src:xgks
Version: 2.6.1+dfsg.2-16
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/xgks_2.6.1+dfsg.2-16_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |            ^~~~~~~~~
cgmi.c:1102:31: error: too many arguments to function ‘umalloc’; expected 0, have 1
 1102 |     if ((mf->cgmi = (mf_cgmi*)umalloc(sizeof(mf_cgmi))) == NULL)
      |                               ^~~~~~~ ~~~~~~~~~~~~~~~
In file included from ../gks_implem.h:56:
../gks_defines.h:101:16: note: declared here
  101 | extern voidp   umalloc         PROTO((size_t size));
      |                ^~~~~~~
cgmi.c:1108:15: error: too many arguments to function ‘CGMmiClose’; expected 0, have 1
 1108 |         (void)CGMmiClose(mf);
      |               ^~~~~~~~~~ ~~
cgm.h:73:12: note: declared here
   73 | extern int CGMmiClose   PROTO((
      |            ^~~~~~~~~~
cgmi.c: In function ‘CGMmiClose’:
cgmi.c:1139:1: warning: old-style function definition [-Wold-style-definition]
 1139 | CGMmiClose(mf)
      | ^~~~~~~~~~
cgmi.c:1141:1: error: number of arguments doesn’t match prototype
 1141 | {
      | ^
cgm.h:73:12: error: prototype declaration
   73 | extern int CGMmiClose   PROTO((
      |            ^~~~~~~~~~
cgmi.c:1148:9: error: too many arguments to function ‘ufree’; expected 0, have 1
 1148 |         ufree((voidp)mf->cgmi);
      |         ^~~~~ ~~~~~~~~~~~~~~~
../gks_defines.h:100:16: note: declared here
  100 | extern void    ufree           PROTO((voidp ptr));
      |                ^~~~~
cgmi.c: In function ‘CGMnextItem’:
cgmi.c:1161:1: warning: old-style function definition [-Wold-style-definition]
 1161 | CGMnextItem(mf)
      | ^~~~~~~~~~~
cgmi.c:1163:1: error: number of arguments doesn’t match prototype
 1163 | {
      | ^
cgm.h:55:12: error: prototype declaration
   55 | extern int CGMnextItem  PROTO((
      |            ^~~~~~~~~~~
cgmi.c: In function ‘CGMreadItem’:
cgmi.c:1216:1: warning: old-style function definition [-Wold-style-definition]
 1216 | CGMreadItem(mf, record)
      | ^~~~~~~~~~~
cgmi.c:1219:1: error: number of arguments doesn’t match prototype
 1219 | {
      | ^
cgm.h:65:12: error: prototype declaration
   65 | extern int CGMreadItem  PROTO((
      |            ^~~~~~~~~~~
cgmi.c: In function ‘mi_octet’:
cgmi.c:105:12: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  105 |     (void) fread((voidp)&data, (size_t)1, (size_t)1, mi->fp);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cgmi.c: In function ‘mi_pcw’:
cgmi.c:69:12: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   69 |     (void) fread((voidp)bytes, (size_t)1, (size_t)2, fp);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[5]: *** [Makefile:135: cgmi.o] Error 1
make[5]: Leaving directory '/build/reproducible-path/xgks-2.6.1+dfsg.2/build-gfortran/lib/c/cgm'
make[4]: *** [Makefile:102: cgm/all] Error 1
make[4]: Leaving directory '/build/reproducible-path/xgks-2.6.1+dfsg.2/build-gfortran/lib/c'
make[3]: *** [Makefile:57: c/all] Error 1
make[3]: Leaving directory '/build/reproducible-path/xgks-2.6.1+dfsg.2/build-gfortran/lib'
make[2]: *** [Makefile:75: lib/all] Error 1
make[2]: Leaving directory '/build/reproducible-path/xgks-2.6.1+dfsg.2/build-gfortran'
make[1]: *** [debian/rules:46: override_dh_auto_build] Error 2
make[1]: Leaving directory '/build/reproducible-path/xgks-2.6.1+dfsg.2'
make: *** [debian/rules:11: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2