Bug#1093361: testu01: FTBFS: error: too many arguments to function 'isaac'

[Santiago Vila]

Package: src:testu01
Version: 1.2.3+ds1-2.1
Severity: serious
Tags: ftbfs trixie sid

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

--------------------------------------------------------------------------------
[...]
libtool: compile:  gcc -std=gnu23 -DHAVE_CONFIG_H -I. -I../../testu01 -I../include -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-unused-result -g -O3 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c ../../testu01/ufile.c  -fPIC -DPIC -o .libs/libtestu01_la-ufile.o
In file included from ../../testu01/ucrypto.c:515:
../../testu01/ucryptoIS.c: In function 'isaac':
../../testu01/ucryptoIS.c:199:17: warning: old-style function definition [-Wold-style-definition]
  199 | static void     isaac(ctx)
      |                 ^~~~~
../../testu01/ucryptoIS.c: In function 'randinit':
../../testu01/ucryptoIS.c:236:13: warning: old-style function definition [-Wold-style-definition]
  236 | static void randinit(ctx, flag)
      |             ^~~~~~~~
../../testu01/ucryptoIS.c:285:4: error: too many arguments to function 'isaac'
  285 |    isaac(ctx);            /* fill in the first set of results */
      |    ^~~~~
../../testu01/ucryptoIS.c:199:17: note: declared here
  199 | static void     isaac(ctx)
      |                 ^~~~~
../../testu01/ucryptoIS.c: In function 'ISAAC_Bits':
../../testu01/ucryptoIS.c:158:7: error: too many arguments to function 'isaac'
  158 |      (isaac(r), (r)->randcnt=RANDSIZ-1, (r)->randrsl[(r)->randcnt]) : \
      |       ^~~~~
../../testu01/ucryptoIS.c:297:10: note: in expansion of macro 'rand'
  297 |   return rand(&ctx);
      |          ^~~~
../../testu01/ucryptoIS.c:199:17: note: declared here
  199 | static void     isaac(ctx)
      |                 ^~~~~
../../testu01/ucryptoIS.c: In function 'ucrypto_CreateISAAC':
../../testu01/ucryptoIS.c:355:7: error: too many arguments to function 'randinit'
  355 |       randinit(&ctx, TRUE);
      |       ^~~~~~~~
../../testu01/ucryptoIS.c:236:13: note: declared here
  236 | static void randinit(ctx, flag)
      |             ^~~~~~~~
../../testu01/ucryptoIS.c:363:7: error: too many arguments to function 'randinit'
  363 |       randinit(&ctx, TRUE);
      |       ^~~~~~~~
../../testu01/ucryptoIS.c:236:13: note: declared here
  236 | static void randinit(ctx, flag)
      |             ^~~~~~~~
make[4]: *** [Makefile:793: libtestu01_la-ucrypto.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
libtool: compile:  gcc -std=gnu23 -DHAVE_CONFIG_H -I. -I../../testu01 -I../include -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-unused-result -g -O3 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c ../../testu01/ufile.c -o libtestu01_la-ufile.o >/dev/null 2>&1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/_build/testu01'
make[3]: *** [Makefile:490: all] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/_build/testu01'
make[2]: *** [Makefile:537: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/_build'
dh_auto_build: error: cd _build && make -j2 returned exit code 2
make[1]: *** [debian/rules:37: override_dh_auto_build-arch] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:24: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202501/

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and add an affects on src:testu01, so that this is still
visible in the BTS web page for this package.

Thanks.