Bug#1108640: coda: FTBFS with HDF 4.3.1

[Bas Couwenberg]

Source: coda
Version: 2.25.5-1
Severity: important
Tags: ftbfs patch
Control: tags -1 forky sid
User: debian-gis at lists.debian.org
Usertags: hdf4-4.3.1

Dear Maintainer,

Your package FTBFS with HDF4 4.3.1 in experimental because the -alt libraries were removed.

The attached patch fixes the issue, but cannot be used for the package in unstable until libhdf4 has been updated in unstable sometime after the trixie release.

Kind Regards,

Bas
-------------- next part --------------
diff -Nru coda-2.25.5/debian/control coda-2.25.5/debian/control
--- coda-2.25.5/debian/control	2025-03-14 09:19:57.000000000 +0100
+++ coda-2.25.5/debian/control	2025-07-02 08:47:55.000000000 +0200
@@ -11,7 +11,7 @@
  libaec-dev,
  libpcre2-dev,
  libexpat1-dev,
- libhdf4-alt-dev,
+ libhdf4-dev,
  python3-all-dev,
  zlib1g-dev,
  swig,
diff -Nru coda-2.25.5/debian/patches/hdf4-alt-libs.patch coda-2.25.5/debian/patches/hdf4-alt-libs.patch
--- coda-2.25.5/debian/patches/hdf4-alt-libs.patch	2025-03-14 09:19:57.000000000 +0100
+++ coda-2.25.5/debian/patches/hdf4-alt-libs.patch	1970-01-01 01:00:00.000000000 +0100
@@ -1,39 +0,0 @@
-Description: Use hdf4 alt library in Debian
-Author: Alastair McKinstry <mckinstry at debian.org>
-Last-Updated: 2018-01-27
-Forwarded: not-needed
-
---- a/m4/hdf4.m4
-+++ b/m4/hdf4.m4
-@@ -15,26 +15,20 @@
- if test "$HDF4_INCLUDE" != "" ; then
-   CPPFLAGS="-I$HDF4_INCLUDE $CPPFLAGS"
- fi
-+HDF4DFLIB=-ldfalt
- AC_CHECK_HEADERS(hdf.h)
- AC_CHECK_HEADERS(netcdf.h)
- AC_CHECK_HEADERS(mfhdf.h)
--HDF4DFLIB=-ldf
--AC_CHECK_LIB(df, Hopen, ac_cv_lib_df=yes, ac_cv_lib_df=no, [ $ZLIB $JPEGLIB $SZLIB])
--if test $ac_cv_lib_df = no ; then
--  AC_CHECK_LIB(hdf, Hopen, ac_cv_lib_hdf=yes, ac_cv_lib_hdf=no, [ $ZLIB $JPEGLIB $SZLIB])
--  if test $ac_cv_lib_hdf = yes ; then
--    HDF4DFLIB=-lhdf
--  fi
--fi
--AC_CHECK_LIB(mfhdf, SDstart, ac_cv_lib_mfhdf=yes, ac_cv_lib_mfhdf=no, [ $HDF4DFLIB $ZLIB $JPEGLIB $SZLIB])
-+AC_CHECK_LIB(dfalt, Hopen, ac_cv_lib_df=yes, ac_cv_lib_df=no, [ $ZLIB $JPEGLIB $SZLIB])
-+AC_CHECK_LIB(mfhdfalt, SDstart, ac_cv_lib_mfhdf=yes, ac_cv_lib_mfhdf=no, [ -ldfalt $ZLIB $JPEGLIB $SZLIB])
- if test $ac_cv_header_hdf_h = no || test $ac_cv_header_mfhdf_h = no ||
--   (test $ac_cv_lib_df = no && test $ac_cv_lib_hdf = no) || test $ac_cv_lib_mfhdf = no ; then
-+  (test $ac_cv_lib_df = no && test $ac_cv_lib_hdf = no) || test $ac_cv_lib_mfhdf = no ; then
-   st_cv_have_hdf4=no
-   CPPFLAGS=$old_CPPFLAGS
-   LDFLAGS=$old_LDFLAGS
- else
-   st_cv_have_hdf4=yes
--  HDF4LIBS="-lmfhdf $HDF4DFLIB $ZLIB $JPEGLIB $SZLIB"
-+  HDF4LIBS="-lmfhdfalt -ldfalt $ZLIB $JPEGLIB $SZLIB"
- fi
- AC_MSG_CHECKING(for HDF4 installation)
- AC_MSG_RESULT($st_cv_have_hdf4)
diff -Nru coda-2.25.5/debian/patches/series coda-2.25.5/debian/patches/series
--- coda-2.25.5/debian/patches/series	2025-03-14 09:19:57.000000000 +0100
+++ coda-2.25.5/debian/patches/series	2025-07-02 08:47:55.000000000 +0200
@@ -1,6 +1,5 @@
 examples-path.patch
 use-system-libs.patch
-hdf4-alt-libs.patch
 detect_libaec.patch
 hdf4-deps.patch
 implicit-function-declaration.patch