Bug#1108653: harp: FTBFS with HDF 4.3.1

[Bas Couwenberg]

Source: harp
Version: 1.25-1
Severity: important
Tags: ftbfs patch
Control: tags -1 forky sid
User: debian-gis at lists.debian.org
Usertags: hdf4-4.3.1

Dear Maintainer,

Your package FTBFS with HDF4 4.3.1 in experimental because the -alt libraries were removed.

The attached patch fixes the issue, but cannot be used for the package in unstable until libhdf4 has been updated there sometime after the trixie release.

Kind Regards,

Bas
-------------- next part --------------
diff -Nru harp-1.25/debian/control harp-1.25/debian/control
--- harp-1.25/debian/control	2025-03-21 11:53:22.000000000 +0100
+++ harp-1.25/debian/control	2025-07-02 11:08:18.000000000 +0200
@@ -17,7 +17,7 @@
  libaec-dev,
  libjpeg-dev,
  zlib1g-dev,
- libhdf4-alt-dev,
+ libhdf4-dev,
  libexpat1-dev,
  libudunits2-dev,
  flex,
diff -Nru harp-1.25/debian/patches/hdf4-alt-libs.patch harp-1.25/debian/patches/hdf4-alt-libs.patch
--- harp-1.25/debian/patches/hdf4-alt-libs.patch	2025-03-21 11:53:22.000000000 +0100
+++ harp-1.25/debian/patches/hdf4-alt-libs.patch	1970-01-01 01:00:00.000000000 +0100
@@ -1,37 +0,0 @@
-Description: Use hdf4 alt library in Debian
-Author: Alastair McKinstry <mckinstry at debian.org>
-Last-Updated: 2018-01-27
-Forwarded: not-needed
-
-Index: harp-1.4/m4/hdf4.m4
-===================================================================
---- harp-1.4.orig/m4/hdf4.m4
-+++ harp-1.4/m4/hdf4.m4
-@@ -18,15 +18,15 @@ fi
- AC_CHECK_HEADERS(hdf.h)
- AC_CHECK_HEADERS(netcdf.h)
- AC_CHECK_HEADERS(mfhdf.h)
--HDF4DFLIB=-ldf
--AC_CHECK_LIB(df, Hopen, ac_cv_lib_df=yes, ac_cv_lib_df=no, [ $ZLIB $JPEGLIB $SZLIB])
-+HDF4DFLIB=-ldfalt
-+AC_CHECK_LIB(dfalt, Hopen, ac_cv_lib_df=yes, ac_cv_lib_df=no, [ $ZLIB $JPEGLIB $SZLIB])
- if test $ac_cv_lib_df = no ; then
-   AC_CHECK_LIB(hdf, Hopen, ac_cv_lib_hdf=yes, ac_cv_lib_hdf=no, [ $ZLIB $JPEGLIB $SZLIB])
-   if test $ac_cv_lib_hdf = yes ; then
-     HDF4DFLIB=-lhdf
-   fi
- fi
--AC_CHECK_LIB(mfhdf, SDstart, ac_cv_lib_mfhdf=yes, ac_cv_lib_mfhdf=no, [ $HDF4DFLIB $ZLIB $JPEGLIB $SZLIB])
-+AC_CHECK_LIB(mfhdfalt, SDstart, ac_cv_lib_mfhdf=yes, ac_cv_lib_mfhdf=no, [ $HDF4DFLIB $ZLIB $JPEGLIB $SZLIB])
- if test $ac_cv_header_hdf_h = no || test $ac_cv_header_mfhdf_h = no ||
-    (test $ac_cv_lib_df = no && test $ac_cv_lib_hdf = no) || test $ac_cv_lib_mfhdf = no ; then
-   st_cv_have_hdf4=no
-@@ -34,7 +34,7 @@ if test $ac_cv_header_hdf_h = no || test
-   LDFLAGS=$old_LDFLAGS
- else
-   st_cv_have_hdf4=yes
--  HDF4LIBS="-lmfhdf $HDF4DFLIB $ZLIB $JPEGLIB $SZLIB"
-+  HDF4LIBS="-lmfhdfalt $HDF4DFLIB $ZLIB $JPEGLIB $SZLIB"
- fi
- AC_MSG_CHECKING(for HDF4 installation)
- AC_MSG_RESULT($st_cv_have_hdf4)
diff -Nru harp-1.25/debian/patches/series harp-1.25/debian/patches/series
--- harp-1.25/debian/patches/series	2025-03-21 11:53:22.000000000 +0100
+++ harp-1.25/debian/patches/series	2025-07-02 11:10:11.000000000 +0200
@@ -1,5 +1,4 @@
 detect_libaec.patch
-hdf4-alt-libs.patch
 use-system-libs.patch
 use-debian-javascript.patch
 python3.patch