Bug#1068174: yosys: Please package the latest upstream release

[Scott Ashcroft]

Hi,

On Fri, 2025-03-14 at 21:10 +0100, Daniel Gröber wrote:
> tl;dr: yosys packaging still has issues in the docs build. Python/sphinx
> help wanted :-).

I'd love to help but something seems to have gone wrong with the
pristine-tar branch so I can't build anything.

When I try to build the package I get:

$ gbp buildpackage
gbp:info: Creating /home/scott/yosys_0.49.orig.tar.gz
gbp:error: Error creating yosys_0.49.orig.tar.gz: Pristine-tar couldn't
checkout "yosys_0.49.orig.tar.gz": fatal: ambiguous argument
'20a7873377c94821e2eeda737aaf35fab389d8cc^{tree}': unknown revision or
path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: not a valid object name:
20a7873377c94821e2eeda737aaf35fab389d8cc^{tree}
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors
pristine-tar: command failed: git archive --format=tar
20a7873377c94821e2eeda737aaf35fab389d8cc\^\{tree\} | (cd
'/tmp/pristine-tar.SloBuAU6Sk' && tar x)

[I see the same sort of errors happening in the CI on salsa.]

It looks like this bug in git-buildpackage:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031693

might screwed things up when you did the import-orig.

> Now when I build in sbuild I still get a number of failures. For one
> Makefile's rsync dependency isn't declared. Easy fix already done. This
> type of thing is why we usually build with some kind of isolated builder
> and not using debuild/dpkg-buildpackage directly on our workstation.

I'm setting up sbuild now. For some reason I thought that using gbp
sorted out the isolation but that's obviously not the case.

> Then build-indep breaks because of python problems:
> 
> ```
> ./yosys-smtbmc --help > docs/source/generated/yosys-smtbmc
> Traceback (most recent call last):
>   File "/build/yosys-ghivvZ/yosys-0.49/./yosys-smtbmc", line 22, in <module>
>     from smtio import SmtIo, SmtOpts, MkVcd
> ModuleNotFoundError: No module named 'smtio'
> make: *** [Makefile:1034: docs/source/generated/yosys-smtbmc] Error 1
> dh_auto_build: error: make -j1 "INSTALL=install --strip-program=true" docs DOC_TARGET=latexpdf -j1 returned exit code 2


I didn't see that as my non-isolated builds would have picked up the
old versions of the python files from /usr/share/yosys since I had
yosys installed.
I think the fix will be to set $PYTHONPATH to point to the correct
directory in the source while the docs are being built. That way the
installed code won't have random paths embedded in it.

> Finally sphinx complains:
> 
>     build finished with problems, 89 warnings (with warnings treated as errors).

Do you get images in the pdfs?

If not I guess there's probably some extra bit of sphinx needed.
If you do then it might be yet another build ordering issue.

Cheers,
Scott