Bug#1117142: gap-float: link against -lgap and remove ${gapkernel:Depends}

[Bill Allombert]

Source: gap-float
Version: 1.0.3+ds-3
Severity: important

Hi Jérome,

gap-float needs to be linked against libgap explicitly with -lgap
so that dpkg-shlibdeps adds the missing dependency on libgap10.

Please use this opportunity to remove support for ${gapkernel:Depends}
which is no more needed or supported.

If you cannot fix this at short notice, tell me and I will ask for a binNMU
for the time being, or I can do an NMU if you prefer.

This is needed for GAP 4.15.0.

I join patches.

Cheers,
-- 
Bill. <ballombe at debian.org>

Imagine a large red swirl here. 
-------------- next part --------------
Index: gap-float-1.0.9+ds/src/Makefile.am
===================================================================
--- gap-float-1.0.9+ds.orig/src/Makefile.am
+++ gap-float-1.0.9+ds/src/Makefile.am
@@ -13,7 +13,7 @@ gaplib_LTLIBRARIES = float.la
 float_la_SOURCES = floatconfig.h floattypes.h float.c
 float_la_CPPFLAGS = $(GAP_CPPFLAGS)
 float_la_CFLAGS = $(GAP_CFLAGS)
-float_la_LDFLAGS = $(GAP_LDFLAGS) -avoid-version -module -Wl,--version-script,$(top_srcdir)/debian/float.map
+float_la_LDFLAGS = $(GAP_LDFLAGS) -lgap -avoid-version -module -Wl,--version-script,$(top_srcdir)/debian/float.map
 float_la_LIBADD =
 
 if SYS_IS_CYGWIN
-------------- next part --------------
diff -Nru gap-float-1.0.9+ds/debian/changelog gap-float-1.0.9+ds/debian/changelog
--- gap-float-1.0.9+ds/debian/changelog	2025-08-30 23:41:01.000000000 +0200
+++ gap-float-1.0.9+ds/debian/changelog	2025-10-03 19:00:41.000000000 +0200
@@ -1,3 +1,13 @@
+gap-float (1.0.9+ds-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Debianization:
+    - d/patches/*!
+      - d/p/link_with-lgap: added.
+        Make sure float.so is linked against libgap.
+
+ -- Bill Allombert <ballombe at debian.org>  Fri, 03 Oct 2025 19:00:41 +0200
+
 gap-float (1.0.9+ds-1) unstable; urgency=medium
 
   * New upstream nano version.
diff -Nru gap-float-1.0.9+ds/debian/control gap-float-1.0.9+ds/debian/control
--- gap-float-1.0.9+ds/debian/control	2025-03-16 01:28:16.000000000 +0100
+++ gap-float-1.0.9+ds/debian/control	2025-10-03 19:00:41.000000000 +0200
@@ -18,7 +18,7 @@
 Package: gap-float
 Provides: gap-pkg-float
 Architecture: any
-Depends: ${misc:Depends}, ${shlibs:Depends}, ${gapkernel:Depends}, gap (>=4.13.0)
+Depends: ${misc:Depends}, ${shlibs:Depends}
 Description: multi-precision floating-point computation for GAP
  GAP is a system for computational discrete algebra with particular
  emphasis on computational group theory, but which has already proved
diff -Nru gap-float-1.0.9+ds/debian/patches/link_with-lgap gap-float-1.0.9+ds/debian/patches/link_with-lgap
--- gap-float-1.0.9+ds/debian/patches/link_with-lgap	1970-01-01 01:00:00.000000000 +0100
+++ gap-float-1.0.9+ds/debian/patches/link_with-lgap	2025-10-03 19:00:41.000000000 +0200
@@ -0,0 +1,13 @@
+Index: gap-float-1.0.9+ds/src/Makefile.am
+===================================================================
+--- gap-float-1.0.9+ds.orig/src/Makefile.am
++++ gap-float-1.0.9+ds/src/Makefile.am
+@@ -13,7 +13,7 @@ gaplib_LTLIBRARIES = float.la
+ float_la_SOURCES = floatconfig.h floattypes.h float.c
+ float_la_CPPFLAGS = $(GAP_CPPFLAGS)
+ float_la_CFLAGS = $(GAP_CFLAGS)
+-float_la_LDFLAGS = $(GAP_LDFLAGS) -avoid-version -module -Wl,--version-script,$(top_srcdir)/debian/float.map
++float_la_LDFLAGS = $(GAP_LDFLAGS) -lgap -avoid-version -module -Wl,--version-script,$(top_srcdir)/debian/float.map
+ float_la_LIBADD =
+ 
+ if SYS_IS_CYGWIN
diff -Nru gap-float-1.0.9+ds/debian/patches/series gap-float-1.0.9+ds/debian/patches/series
--- gap-float-1.0.9+ds/debian/patches/series	2025-08-30 23:34:28.000000000 +0200
+++ gap-float-1.0.9+ds/debian/patches/series	2025-10-03 19:00:20.000000000 +0200
@@ -2,3 +2,4 @@
 upstream-autotoolization-cleanup.patch
 debianization.patch
 debianization-documentation.patch
+link_with-lgap
diff -Nru gap-float-1.0.9+ds/debian/rules gap-float-1.0.9+ds/debian/rules
--- gap-float-1.0.9+ds/debian/rules	2024-04-13 15:35:58.000000000 +0200
+++ gap-float-1.0.9+ds/debian/rules	2025-10-03 19:00:41.000000000 +0200
@@ -4,10 +4,6 @@
 
 DEB_BUILD_MULTIARCH  ?= $(shell dpkg-architecture -qDEB_BUILD_MULTIARCH)
 DEB_BUILD_GAP_INFO_ARCH ?= $(shell echo 'Print(GAPInfo.Architecture);' | $(CGAP) -A -q -T)
-##DEB_BUILD_GAP_KERNEL_MAJOR_VERSION ?= $(shell sed -n -e 's/^GAP_KERNEL_MAJOR_VERSION=//p' /usr/lib/gap/sysinfo.gap )
-
-SUBSTVARS = -Vgapkernel:Depends=""
-##SUBSTVARS = -Vgapkernel:Depends="gap-kernel-$(DEB_BUILD_GAP_KERNEL_MAJOR_VERSION)"
 
 default:
 	@uscan --no-conf --dehs --report || true