Bug#1127629: lib3ds: autopkgtest failure with glibc 2.43 due to ISO C23 const return types

[Aurelien Jarno]

Source: lib3ds
Version: 1.3.0-10
Severity: important
Tags: upstream
User: debian-glibc at lists.debian.org
Usertags: glibc-2.43

Dear maintainer,

lib3ds autopkgtest fails when run against libc 2.43, currently in
experimental. From the autopkgtest log:

| 31s autopkgtest [02:42:14]: test build1: [-----------------------
| 31s demo.c: In function ‘Basename’:
| 31s demo.c:1270:15: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
| 31s  1270 |   char *ptr = strrchr(filename, '/');
| 31s       |               ^~~~~~~
| 31s build: OK
| 32s autopkgtest [02:42:15]: test build1: -----------------------]

...

| 32s autopkgtest [02:42:15]: @@@@@@@@@@@@@@@@@@@@ summary
| 32s build1               FAIL stderr: demo.c: In function ‘Basename’:

The full autopkgtest log is available there:
https://ci.debian.net/data/autopkgtest/unstable/amd64/lib3/lib3ds/68528647/log.gz

The issue is due to ISO C23 declaration of strrchr, which now returns a
pointer to a const-qualified type when the input argument is a pointer
to a const-qualified type [1]. This emits a warning on stderr, which is
then caught by debci.

Regards
Aurelien