Bug#1128758: ucx: FTBFS with glibc 2.43 due to ISO C23 const return types

[Aurelien Jarno]

Source: ucx
Version: 1.20.0+ds-4
Severity: important
Tags: ftbfs upstream
Justification: fails to build from source
User: debian-glibc at lists.debian.org
Usertags: glibc-2.43

Dear maintainer(s),

ucx fails to build from source with glibc 2.43, currently in
experimental. From the build log:

| config/parser.c: In function 'ucs_config_sscanf_bw_spec':
| config/parser.c:649:11: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
|   649 |     delim = strchr(buf, ':');
|       |           ^

...

| cc1: all warnings being treated as errors
| make[4]: *** [Makefile:1675: config/libucs_la-parser.lo] Error 1
| make[4]: *** Waiting for unfinished jobs....
| make[4]: Leaving directory '/build/reproducible-path/ucx-1.20.0+ds/src/ucs'
| make[3]: *** [Makefile:2146: all-recursive] Error 1
| make[3]: Leaving directory '/build/reproducible-path/ucx-1.20.0+ds/src/ucs'
| make[2]: *** [Makefile:802: all-recursive] Error 1
| make[2]: Leaving directory '/build/reproducible-path/ucx-1.20.0+ds'
| make[1]: *** [Makefile:672: all] Error 2
| make[1]: Leaving directory '/build/reproducible-path/ucx-1.20.0+ds'
| dh_auto_build: error: make -j128 returned exit code 2
| make: *** [debian/rules:23: binary] Error 25
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2

The full build log is available here [1].

The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].

I would like to thanks Emanuele Rocca for doing the archive rebuild on
a fast arm64 server.

Regards
Aurelien

[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/ucx_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net