trilinos_17.0.0+dfsg-3_multi.changes REJECTED

[nils.schild at posteo.de]

Dear Reinhard,

thank you for your review on our package in NEW queue.

On Sun, 5 Jul  2026 at 02:00 Reinhard Tartler wrote:
> - The files under `packages/kokkos/` and `packages/kokkos-kernels/`
> have been updated with the LLVM exception, but the actual copyright
> holder string "Contributors to the Kokkos project" (which appears in
> thousands of files, e.g.,
> `packages/kokkos-kernels/batched/KokkosBatched_Util.cpp`) is still
> entirely missing from `debian/copyright`.
I have two concerns about this.
First the phrase is a wage definition and not real entity or person 
owning a copyright.
Second adding this phrase would be inconsistent with respect to many 
other files in the project (e.g. Stokhos and Zoltan packages).
These packages mention the '(C) Copyright ... and the <PACKAGENAME> 
contributors' but are not required to be used in d/copyright so far.
My impression is that the Kokkos project is only recognized since it 
relies on SPDX headers.
I was told that also for the above reasons 'Contributors to 
<PACKAGENAME>' is usually not used in the d/copyright file.

> - While the catch-all stanza now includes "Sandia National
> Laboratories", there are still verbatim copyright notices that have
> been normalized or omitted. For example, "Sandia Corporation" appears
> in files like `packages/belos/tpetra/example/LSQR/LSQRTpetraExFile.cpp`
> and "National Technology Engineering Solutions of Sandia, LLC"
> (without the ampersand) appears in `packages/krino/` headers. These
> should be mirrored verbatim.
We add Sandia Corporation and LLC to the list of Copyright holders under 
the SNL entity.
Taking a verbatim approach for every file would probably require to list 
significantly more files explicitly in the d/copyright file.
To me this appears as a duplication of information instead of actually 
adding new information.
Since all of these names refer to the same entity, would it not be 
sufficient to cover these in a normalized way?
The dnq tool seemed to trigger (e.g. on the NTESS with ambersand) in the 
second review but not in the first one.
Alternatively to a forward slash separated list I would suggest to list 
the following spellings of NTESS on every occurence of NTESS as a 
copyright holder:
  - National Technology & Engineering Solutions of Sandia, LLC (NTESS)
  - Sandia National Laboratories
  - Sandia Corporation
Since the Copyright for NTESS does not seem to be enforced through 
tooling, my impression is, that the spelling of the NTESS entity is to 
some extent developer dependent.

> - I noticed a slight slip in authorship for the generated EPS files.
> `packages/pamgen/rtcompiler/diag1.eps` and `diag2.eps` attribute
> copyright to "artofcode LLC, Benicia, CA", but this author is missing
> from `debian/copyright`.
On these files Jochen mentioned that the Copyright is probably 
misleading.
Artofcode LCC is connected to ghostscript and these files have probably 
been converted from ghostscript to eps by the authors in writeup.tex.
Therefore, we think this copyright statement should not be added to 
d/copyright.
This would be similar to the copyright statements in TpetraDesign.pdf 
triggered by dnq for AMS and URW.

Best
Nils