Bug#1139312: h5z-zfp: FTBFS against HDF5 2.1.0 - test_error.c:195: main: Assertion `ndiffs == 1408' failed.

[Gilles Filippini]

Control: tags -1 + patch fixed-upstream

Hi,

Gilles Filippini a écrit le 08/06/2026 à 15:28 :
> Source: h5z-zfp
> Version: 1.1.1-2
> Severity: important
> Tags: ftbfs
> 
> Hi,
> 
> During a rebuild against HDF5 2.1.0 currently in experimental, h5z-zfp
> FTBFS with one failed test:
> 
> ./test_error ................................................test_error: test_error.c:195: main: Assertion `ndiffs == 1408' failed.
> 
> The value of 'ndiffs' is 652. I have no idea what it means.
> 
> Since h5z-zfpi is a reverse dependency for several other packages I'd
> appreciate if this could be fixed rapidly.
> 
> I am in touch with HDF5 devs in case their help is needed to understand
> the problem. Just tell me :)
Please find attached a patch from upstream.

Best,
_g.
-------------- next part --------------
diff -Nru h5z-zfp-1.1.1/debian/changelog h5z-zfp-1.1.1/debian/changelog
--- h5z-zfp-1.1.1/debian/changelog	2024-01-19 13:27:49.000000000 +0100
+++ h5z-zfp-1.1.1/debian/changelog	2026-06-13 10:12:25.000000000 +0200
@@ -1,3 +1,11 @@
+h5z-zfp (1.1.1-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Upstream patch pr_168.patch to fix FTBFS against HDF5 2.1.0 (closes:
+    #1139312)
+
+ -- Gilles Filippini <pini at debian.org>  Sat, 13 Jun 2026 10:12:25 +0200
+
 h5z-zfp (1.1.1-2) unstable; urgency=medium
 
   * d/t/control: No need to rebuild, rely on the testbed
diff -Nru h5z-zfp-1.1.1/debian/patches/pr_168.patch h5z-zfp-1.1.1/debian/patches/pr_168.patch
--- h5z-zfp-1.1.1/debian/patches/pr_168.patch	1970-01-01 01:00:00.000000000 +0100
+++ h5z-zfp-1.1.1/debian/patches/pr_168.patch	2026-06-13 10:12:25.000000000 +0200
@@ -0,0 +1,37 @@
+From ee03142d1d1cb4097553c19c450497d5683eba6e Mon Sep 17 00:00:00 2001
+From: Scot Breitenfeld <brtnfld at hdfgroup.org>
+Date: Fri, 12 Jun 2026 08:36:34 -0500
+Subject: [PATCH] Fix test_error chunk offset detection for HDF5 2.1.0 (#167)
+
+Use H5Dget_chunk_info_by_coord (HDF5 1.12+) to dynamically find the
+chunk's file offset instead of the hardcoded value 3496.  HDF5 2.1.0
+changed internal file layout so the chunk no longer lives at that
+address, causing the raw-byte corruption to miss the ZFP stream and
+yielding only 652 differing values instead of the expected 1408.
+---
+ test/test_error.c | 11 ++++++++++-
+ 1 file changed, 10 insertions(+), 1 deletion(-)
+
+diff --git a/test/test_error.c b/test/test_error.c
+index d358fc2..d4a1305 100644
+--- a/test/test_error.c
++++ b/test/test_error.c
+@@ -148,8 +148,17 @@ int main(int argc, char **argv)
+     cpid = setup_filter(1, chunk, zfpmode, rate, acc, prec, minbits, maxbits, maxprec, minexp);
+     if (0 > (dsid = H5Dcreate(fid, "corrupted_data", H5T_NATIVE_DOUBLE, sid, H5P_DEFAULT, cpid, H5P_DEFAULT))) SET_ERROR(H5Dcreate);
+     if (0 > H5Dwrite(dsid, H5T_NATIVE_DOUBLE, H5S_ALL, H5S_ALL, H5P_DEFAULT, buf)) SET_ERROR(H5Dwrite);
+-    off = 3496; // H5Dget_offset(dsid);
++#if H5_VERSION_GE(1,10,5)
++    {
++        hsize_t coord[1] = {0};
++        unsigned filter_mask;
++        /* H5Dget_offset returns HADDR_UNDEF for chunked datasets; use chunk info API instead */
++        if (0 > H5Dget_chunk_info_by_coord(dsid, coord, &filter_mask, &off, &siz)) SET_ERROR(H5Dget_chunk_info_by_coord);
++    }
++#else
++    off = 3496;
+     siz = H5Dget_storage_size(dsid);
++#endif
+     if (0 > H5Dclose(dsid)) SET_ERROR(H5Dclose);
+     if (0 > H5Pclose(cpid)) SET_ERROR(H5Pclose);
+ 
diff -Nru h5z-zfp-1.1.1/debian/patches/series h5z-zfp-1.1.1/debian/patches/series
--- h5z-zfp-1.1.1/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ h5z-zfp-1.1.1/debian/patches/series	2026-06-13 10:12:25.000000000 +0200
@@ -0,0 +1 @@
+pr_168.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/debian-science-maintainers/attachments/20260622/81061e24/attachment-0001.sig>