Bug#1151869: p4est: issues to address following NEW review of 2.8.7-1~exp1

[siretart at debian.org]

Source: p4est
Version: 2.8.7-1~exp1
Severity: serious
X-Debbugs-Cc: debian-science-maintainers at lists.alioth.debian.org

Dear Maintainer,

p4est 2.8.7-1~exp1 was accepted from the NEW queue by the DFSG, Licensing & New
Packages Team. The reviewer asked for the following to be addressed in
a later upload:

Thanks for your diligence. I've taken a look at p4est 2.8.7-1~exp1 and
found a few DFSG and copyright documentation items that need addressing:

- `doc/2002siamnews/Software_p4est_newstest2.pdf`: This is a pre-built
  2-page PDF article ("SIAM News", Vol. 53, No. 1, 2020) included without
  source code or an explicit DFSG-compliant license grant. Note also that
  `debian/copyright` states "Comment: Removed from tarball: doc/*.pdf
  sc/doc/*.pdf", but this PDF remains present in the upstream source.
  The PDF should either have its source provided and license documented,
  or be repacked/excluded from the tarball as intended.

- `sc/iniparser/*`: Embedded copy of iniparser (written by Nicolas
  Devillard) licensed under Expat/MIT as documented in
  `sc/iniparser/LICENSE`, but it is currently unmentioned in
  `debian/copyright` and falls under the generic LGPL-2.1+ stanza.
  (Additionally, `sc/iniparser/inistring.{c,h}` carry a 2-clause BSD
  notice by "individual authors".)

- `sc/libb64/*`: Embedded copy of libb64 (by Chris Venter) released
  into the public domain / CC-PDDC as declared in `sc/libb64/LICENSE`,
  but unmentioned in `debian/copyright`.

- `sc/src/sc_puff.{c,h}` (and `sc/doc/attic/puff.h`): Written by Mark
  Adler under the zlib license ("Copyright (C) 2002-2013 Mark Adler"),
  but missing from `debian/copyright`.

- `build-aux/git2cl` and `sc/build-aux/git2cl`: `debian/copyright` lists
  only Simon Josefsson for git2cl, but the header explicitly attributes
  copyright for derived functions to Martyn J. Pearce
  <fluffy at cpan.org> (2001-2004) and Karl Fogel <kfogel at red-bean.com> (1999).

- 2-clause BSD files in `sc/`: Several files (`sc/src/sc_uint128.{c,h}`,
  `sc/src/sc3_mpi_types.h`, `sc/test/test_helpers.c`,
  `sc/test/test_mpi_pack.c`, `sc/test/test_version.c`) carry a 2-clause
  BSD license by "individual authors" rather than the LGPL-2.1+ stated
  for `sc/*`.

- `sc/doc/attic/config/sc_lint.m4`: Sun Microsystems copyright (2005-2006)
  under the X11 license is documented for `sc/config/sc_lint.m4`, but that
  file was moved upstream to `sc/doc/attic/config/sc_lint.m4`. Similarly,
  `sc/doc/attic/sc_obstack.c` moved from `sc/src/sc_obstack.c`.

Please update `debian/copyright` and address the PDF in your next upload.

-rt

Full review details: https://dfsg-new-queue.debian.org/reviews/p4est

Regards, Reinhard Tartler