<div dir="ltr">Done [1] and done [2]. Graham, you might want to subscribe to those PRs.<div><br></div><div>Cheers,</div><div>Nico<br><div><br></div><div>[1] <a href="https://github.com/kokkos/kokkos/pull/576">https://github.com/kokkos/kokkos/pull/57</a>5</div><div>[2] <a href="https://github.com/kokkos/kokkos/pull/576">https://github.com/kokkos/kokkos/pull/576</a></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 9, 2016 at 11:22 AM Graham Inggs <<a href="mailto:ginggs@debian.org">ginggs@debian.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 9 December 2016 at 09:49, Nico Schlömer <<a href="mailto:nico.schloemer@gmail.com" class="gmail_msg" target="_blank">nico.schloemer@gmail.com</a>> wrote:<br class="gmail_msg">
> The patch looks really simple. Great! Do you think it'd be worthwhile<br class="gmail_msg">
> updating the PR [1] (or opening a new one)? Perhaps the kokkos devs can<br class="gmail_msg">
> figure out why the remaining tests are failing.<br class="gmail_msg">
<br class="gmail_msg">
No harm in trying, I guess. :)<br class="gmail_msg">
Please update the PR, but I suggest leaving out the static_asserts,<br class="gmail_msg">
i.e. don't include the changes to Kokkos_Core_fwd.hpp and<br class="gmail_msg">
Kokkos_TaskQueue.hpp.<br class="gmail_msg">
Also, I think the changes to Kokkos_Macros.hpp from<br class="gmail_msg">
kokkos-disable-asm.patch should go in a separate PR.  Hopefully they<br class="gmail_msg">
can merge that right away.<br class="gmail_msg">
</blockquote></div>