<div dir="ltr">The patch looks really simple. Great! Do you think it'd be worthwhile updating the PR [1] (or opening a new one)? Perhaps the kokkos devs can figure out why the remaining tests are failing.<div><br></div><div>Cheers,</div><div>Nico<br><div><br></div><div>[1] <a href="https://github.com/kokkos/kokkos/pull/410">https://github.com/kokkos/kokkos/pull/410</a></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 9, 2016 at 8:18 AM Graham Inggs <<a href="mailto:ginggs@debian.org">ginggs@debian.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Attached is an updated version of kokkos-32-bit.patch against upstream 12.10.1.<br class="gmail_msg">
It turns out that once the templates were fixed, the overloaded<br class="gmail_msg">
function declarations were not needed.<br class="gmail_msg">
<br class="gmail_msg">
Builds and test of Kokkos-only and all Trilinos packages on 64-bit<br class="gmail_msg">
architectures are not affected.<br class="gmail_msg">
<br class="gmail_msg">
On 32-bit architectures that have an 8-byte compare-and-swap<br class="gmail_msg">
implementation (e.g. armhf and i386), a Kokkos-only build is<br class="gmail_msg">
successful, but 1 out of the 21 unit tests,<br class="gmail_msg">
KokkosCore_UnitTest_Serial_MPI_1, fails.<br class="gmail_msg">
KokkosCore_UnitTest_Serial_MPI_1 includes 60 tests and of these only 4<br class="gmail_msg">
fail with errors like:<br class="gmail_msg">
<br class="gmail_msg">
Value of: result[i].value[j]<br class="gmail_msg">
  Actual: 5.00005e+09<br class="gmail_msg">
Expected: (ScalarType) correct<br class="gmail_msg">
Which is: 7.05083e+08<br class="gmail_msg">
<br class="gmail_msg">
A build of all Trilinos packages fails with a few errors similar to<br class="gmail_msg">
the following:<br class="gmail_msg">
<br class="gmail_msg">
packages/tpetra/core/test/Distributor/createfromsendsandrecvs.cpp:315:61:<br class="gmail_msg">
error: conversion from ‘Teuchos::ArrayView<const unsigned int>’ to<br class="gmail_msg">
non-scalar type ‘Teuchos::ArrayView<const long unsigned int>’<br class="gmail_msg">
requested<br class="gmail_msg">
   ArrayView<const long unsigned int> c = dist.getLengthsFrom();<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
For a Kokkos-only build, which saves a huge amount of time (thanks<br class="gmail_msg">
Nico!), make the following changes to debian/rules:<br class="gmail_msg">
<br class="gmail_msg">
--- a/debian/rules<br class="gmail_msg">
+++ b/debian/rules<br class="gmail_msg">
@@ -93,8 +93,9 @@<br class="gmail_msg">
    -DTrilinos_INSTALL_INCLUDE_DIR:PATH=include/trilinos/ \<br class="gmail_msg">
    -DTrilinos_USE_GNUINSTALLDIRS:BOOL=ON \<br class="gmail_msg">
    -DTrilinos_ENABLE_DEVELOPMENT_MODE:BOOL=OFF \<br class="gmail_msg">
-   -DTrilinos_ENABLE_ALL_PACKAGES:BOOL=ON \<br class="gmail_msg">
-   -DTrilinos_ENABLE_SECONDARY_TESTED_CODE:BOOL=ON \<br class="gmail_msg">
+   -DTrilinos_ENABLE_ALL_PACKAGES:BOOL=OFF \<br class="gmail_msg">
+   -DTrilinos_ENABLE_SECONDARY_TESTED_CODE:BOOL=OFF \<br class="gmail_msg">
+   -DTrilinos_ENABLE_Kokkos:BOOL=ON \<br class="gmail_msg">
    -DTrilinos_ASSERT_MISSING_PACKAGES:BOOL=OFF \<br class="gmail_msg">
    -DTrilinos_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON \<br class="gmail_msg">
    -DTrilinos_ENABLE_CTrilinos:BOOL=OFF \<br class="gmail_msg">
</blockquote></div>