[Debian-science-sagemath] Fwd: Bug#888606: cysignals: FTBFS with debhelper/11.1 due to empty build target

[Jerome BENOIT]

Hello,

this issue was fixed in 1.6.6+ds-2 which is current in experimental:
can we migrate cysingals 1.6.6+ds-2 to unstable ?

Thanks,
Jerome


-------- Forwarded Message --------
Subject: Bug#888606: cysignals: FTBFS with debhelper/11.1 due to empty build target
Resent-Date: Sat, 27 Jan 2018 17:51:02 +0000
Resent-From: Niels Thykier <niels at thykier.net>
Resent-To: debian-bugs-dist at lists.debian.org
Resent-CC: Jerome Benoit <calculus at rezozer.net>
Date: Sat, 27 Jan 2018 18:44:34 +0100
From: Niels Thykier <niels at thykier.net>
Reply-To: Niels Thykier <niels at thykier.net>, 888606 at bugs.debian.org
To: Debian Bug Tracking System <submit at bugs.debian.org>

Source: cysignals
Version: 1.6.5+ds-2
Severity: serious
Tags: patch

Hi,

The cysignals package FTBFS with debhelper/11.1 as it has an empty
build target.  This is caused by debhelper had a bug in its handling
of "explicitly defined rules targets" that has now been fixed.

Previously, this happened to work because dpkg-buildpackage would
invoke "debian/rules build" (which would be a no-op) followed by
"fakeroot debian/rules binary".  During the binary target, dh's
suboptimal handling would run the build commands.


The solution is trivial but less pretty; explicitly define "build"
with the same content as the "%:" target (or rename the "build" folder
and drop the ".PHONY" target).  I have attached a patch for this.


More details can be found in:
 * #886901 comment #35
 * #887688 comment #37
 * #880840

Apologies for the inconvenience.

Thanks,
~Niels

-------------- next part --------------
From 3a57538b93ca415f235feb04b19395a576dfc60f Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels at thykier.net>
Date: Sat, 27 Jan 2018 17:43:04 +0000
Subject: [PATCH] Avoid empty build target

The dh sequencer as of debhelper/11.1 is stricter with this in order
to solve #880840 (where debhelper would fail to handle such targets
correctly).

Signed-off-by: Niels Thykier <niels at thykier.net>
---
 debian/rules | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/debian/rules b/debian/rules
index 4872a50..bfd28fb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -18,6 +18,12 @@ default:
 %:
 	dh $@ --with autoreconf --with python2  --with sphinxdoc --buildsystem=pybuild
 
+# The build target must not be empty.  Sadly because of how make
+# works, we have do duplicate the target in this case.
+build:
+	dh $@ --with autoreconf --with python2  --with sphinxdoc --buildsystem=pybuild
+
+
 override_dh_auto_configure-arch:
 	$(call adhoc_dh_auto_configure_do,bare)
 	$(call adhoc_dh_auto_configure_do,pari)
-- 
2.15.1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1528 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-science-sagemath/attachments/20180128/d3ca79a2/attachment.sig>