[Debian-science-sagemath] arb: headers with generic names

[Erik Bray]

On Mon, Sep 10, 2018 at 7:12 AM Ximin Luo <infinity0 at debian.org> wrote:
>
> Julien Puydt:
> > Hi,
> >
> > On 09/09/2018 17:54, Jerome BENOIT wrote:
> >
> >> I have just noticed that some some headers of arb have a very generic name:
> >>
> >>   bernoulli.h
> >>   bool_mat.h
> >>   dirichlet.h
> >>   dlog.h
> >>   hypgeom.h
> >>   mag.h
> >>   partitions.h
> >>
> >> and possibly
> >>
> >>   fmpr.h
> >>   fmpz_extras.h
> >>
> >> while the remaining headers have a more specific prefix: arb, acb, arf .
> >>
> >> I see a potential naming issue here.
> >>
> >> May I fill bug report for this ?
> >
> > Upstream, then, as there's nothing I can do about it in Debian...
> >
>
> Well, we can install on-purpose into a Debian-specific directory like /usr/include/arb instead of /usr/include. Then all the packages that uses arb will have to add -I /usr/include/arb to their compiler flags, or #include <arb/xxx.h> instead of #include <xxx.h>.
>
> In fact I swear we were doing this already, and that we were happy to maintain this patch from upstream because what upstream does is so ridiculous. Did this get reverted or something?
>
> Of course the best solution is to have upstream adopt best practises, but here the situation IMO is too ridiculous to tolerate, we should just fix it in Debian for now, and keep maintaining the patch - which should not be that bad, just mechanical renames.

Rather than patching the sources, wouldn't it make more sense to just
add `-I/usr/include/arb` where necessary?  This can go in a .pc file
for arb.