[Debian-science-sagemath] Bug#838679: Fwd: Bug#838679: RFS: cysignals/1.1.1+ds-1 [ITP] -- interrupt and signal handling for Cython

[Jerome BENOIT]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello Ximin, thanks for your review.

I will try to digest your remarks and to act accordingly.

Meanwhile, you may want to review the nbsphinx package.

Otherwise, right now I am working on the dependencies of ipywidgets.


Thanks,
Jerome

On 28/09/16 19:21, Ximin Luo wrote:
> Ximin Luo:
>> Hey, nice work. I'm taking a look now.
>> 
> 
> Hey, it looks good! I couldn't spot any problems.
> 
> Just the following minor things:
> 
> (1)
> 
> d/rules: override_dh_install-arch: true
> 
> Could you add a comment explaining this? I didn't look in too much
> detail but I couldn't figure out the reason for this. I did run
> dpkg-buildpackage -A and -B checked they still work, so that's good.
> It would be good to add a comment, so future readers don't get
> confused.
> 
> (2)
> 
> Instead of maintaining two separate git branches, I suggest using
> build profiles:
> 
> https://wiki.debian.org/BuildProfileSpec
> 
> I've pushed some commits to the git repo that makes this work
> already, see if you like them, or revert if you don't :p
> 
> The default build will leave out the -pari stuff. To enable the pari
> stuff, you can either :
> 
> a. use `(dpkg-buildpackage|gbp buildpackage) -Ppkg.cysignals.pari`
> or b. set DEB_BUILD_PROFILES=pkg.cysignals.pari for lower-level tools
> like `debian/rules`
> 
> I had to use a slight hack in debian/tests/control but I thought it
> was still worth it, to avoid switching between branches all the
> time.
> 
> If you like this, please also edit debian/README.source to describe
> this new workflow.
> 
> (3)
> 
> You tagged debian/1.1.1+ds-1 already in the git repo. I suggest not
> doing this yet, and delete the current tag - we have some newer
> unreleased commits anyway.
> 
> My preferred workflow is to keep UNRELEASED in d/changelog, then when
> everything is ready I git push, then `dch -r`, commit, build, dput
> and wait for the ACCEPTED email from ftp-masters. Only after I get
> email, do I then run `gbp buildpackage --git-tag-only` and then push
> this last commit plus the tag that was just created.
> 
> Sometimes (like now) there's no point using UNRELEASED if d/changelog
> already says something else, but the rest of the above still works.
> 
> X
> 

- -- 
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calculus@rezozer.net
AE28 AE15 710D FF1D 87E5  A762 3F92 19A6 7F36 C68B
-----BEGIN PGP SIGNATURE-----

iQQcBAEBCgAGBQJX7CMkAAoJED+SGaZ/NsaLLBEgAJ8r4MJDQal4rsxVUS6izOy3
Z4tT1D44+Ps0Ccp5OOTH+tswF0WATVmTmkYtJVu+/2fm8WubMRmNfxyQxD8LntRL
f3L854kRWbINGV6NX3NIFkLzARcN4KUrGpAnWG4kJgnvOPh3pjRY6feXr05HgwnC
wmunrvadF8Ey7cuCEY2btGXAbX9GlB7mAO5f2TV5V+siJG4YLavG2Y6AAxLRfZU2
P65ttuaL8Lz6ivQOxvyF30h76/tuOyIhGTc05x/5x0APjerv6Fia5EgtI3rOBy7b
+g9/zw2fWUpZe5eDZsKEWpqpgaOzC3g4EYQetBhhVvqtjqFBcUN+ddD1OBMxGiFu
DBxtOHv7uHOkq/QAiqiEvRzwC0jAbgAHqofwMpFMUgJioa+UKiEOJf//iBp2r5Ty
h+cJyLKBuBTzSGkOFUX2/z7iPA6EmmUPVxEQmYi0KdNfyuGhEA98S5MNpKi5gwBl
jnuawI1NnruzymHmtIm0bEN0j6M3Nz2nxCYmcAw6EdCkz4/JjzLZzaqvl8UFYPnt
fNVmSI5IyV2l1I+Ixs5yqqEoUaDvjExNimTDEFnPXjV77ViWCmcFpA+LruKSSV3y
TYO7334u6mYGQ+iwQUlvbZ9zmGHAlGZKEcrQgp36UOkeh7XOR81eA/H8tAo0TWTF
ER3wVcRbu0FUqOZrszE25JWCusI29MfVO+9siqI6QKEJ7lxhCq/eyJznU3Y/7yVU
2yHTnq6Z3eWLWZNUfIGVEYBCNSQb+IDfe0LtPdYtwZTcj5aWCdv9p0cdcpqjzHml
Ne/EwI4hdw5BuulAtahrv62+htc0xEX0/Gis0ri2v0fGHsDrHadnkW+NhjIgEOb2
+mCb8MTaP/M7o/ccZNV/c0OC3mep2yX1OnF06zt1sfqoo+FCnHUZpmitXsw58Ao2
MOY8uvYur0SkJcI1CBNryR5E4u8Fg1gjDwCHi9tLTi7JvVTyClJ4C390j7E1+y6v
prxnJsHWkw2A/FctEStpQlKyJ4dMQlTSYdWigwb1N51tjqaikz28T0VrZ3+aBubf
wCRoKhTmw4AB2XbZT4qHHzKrekZg1FK73fOg+aTuM6IWxaODJihyGhKJIOjltuqY
2sopqk8gmWlkP4ZEvYInRUfkDujUPQAMQA+GvE/P/h/JSPd0yjwRbf1u2Aa3BO7y
v5N/JHmuIea8vih15NVsLsY3vX2WUUQnjbCgo2xxZknqa+3oaD69siHgU/Mj4mRe
ftyhKHXvcwJgypUvTeX7pRRMNtgVtObglfQ3qOTBAb6u2wOMgEjH2xM6ePbAqGiy
Fduef5h6KjYTd3k+hnJ8t/9CskNXH5SIjpe0zi4mfjeNBVWZZXTs94mMptbu3Xo=
=TDO1
-----END PGP SIGNATURE-----